Conversation
|
I like having the version specific templates separate, but would go a step forward and put the newest template as well in that directory and make the top level, “unversioned” file just a symlink to the latest template. |
|
@foca interesting idea. I'd actually prefer to deprecate the use of symlinks because Windows support for it is still suboptimal, but I'll keep that in mind. |
|
Ah, that’s a good point. Shouldn’t respond to issues before my first
coffee. Disregard, then :)
…On October 27, 2018 at 10:50:31, Brendan Forster ***@***.***) wrote:
@foca <https://github.com/foca> interesting idea. I'd actually prefer to
deprecate the use of symlinks because Windows support for it is still
suboptimal, but I'll keep that in mind.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2857 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABte_KJeXoTEGzoyvwXpr--RILeV1lks5upGSngaJpZM4X9bog>
.
|
f341652 to
520ab04
Compare
Co-Authored-By: Luís Pedro Algarvio <lp@algarvio.org>
Co-Authored-By: Luís Pedro Algarvio <lp@algarvio.org>
Co-Authored-By: Nolwennig <nolwennig@users.noreply.github.com>
Co-Authored-By: FURUKAWA,Daisuke <mogya at mogya.com>
Co-Authored-By: JuanPablo <jpabloaj@gmail.com> Co-Authored-By: Sean Callan <sean@seancallan.com>
Co-Authored-By: Martin Kuric <martin.chix.kuric@gmail.com>
Co-Authored-By: Parallel <swumao@users.noreply.github.com>
Co-Authored-By: 林博仁(Buo-ren Lin) <lin-buo-ren@users.noreply.github.com> Co-Authored-By: Marius Gripsgard <marius@ubports.com>
Co-Authored-By: Julien Liabeuf <julien731@users.noreply.github.com> Co-Authored-By: Ricardo N Feliciano <ricardo@feliciano.tech>
Co-Authored-By: SouthWolf <wp.southwolf@gmail.com> Co-Authored-By: Trent Patterson <jtrent238@outlook.com> Co-Authored-By: PeterWAWood <peterwawood@users.noreply.github.com>
Co-Authored-By: Marcos Estevam <estevamdf2@users.noreply.github.com>
Co-Authored-By: Christopher Jennings <christopherjennings@users.noreply.github.com>
Co-Authored-By: Customer FX Development <customerfx@users.noreply.github.com>
Co-Authored-By: CodeHunter <codehunter@users.noreply.github.com>
Co-Authored-By: moltra <strickland41@live.marshall.edu>
Co-Authored-By: Will Price <willprice94+dev@gmail.com> Co-Authored-By: Stefan <eu90h@users.noreply.github.com>
@Lin-Buo-Ren personal preference mostly. If I was around for when |
|
good work =) |
|
@shiftkey just a minor correction, drupal is php but was by mistake placed under python. can you fix it? id provide a patch, but i have my week and weekend overdosed with work and responsabilities |
|
@lpalgarvio I'm also swamped (and trying to wrap things up before going on holidays tomorrow) so either it'll get done after that or someone can submit a change... |
This PR is my attempt to address some limits of how templates are currently organised, so I can potentially land some newer templates and not lose my sanity.
Rendered README
But why?
Here's my current hell:
This PR introduces an
communitysubdirectory, to help better organise templates. The core flows I want to address are:The root of the repository will remain focused on active and popular templates, but organising things means we can support a more diverse range of templates in the future.
Supporting different versions of a framework
The first example is the current situation with Drupal. Here's two PRs waiting for my review:
Rather than have two versioned templates at the root for
Drupal8.gitignoreandDrupal7.gitignorewe should move to this pattern for major frameworks:Drupal.gitignoreas the evergreen "latest" templatecommunity/Python/Drupal7.gitignorefor those who need to access the older templateAt some point in the future, if Drupal 9 has significant changes, we can go through the flow again:
Drupal.gitignoreis updated to support Drupal 9's rulescommunity/Python/Drupal8.gitignoreis added with the old rulesAnother example is this PR:
In this PR I've instead gone with this flow:
community/PHP/Magento1.gitignorefor those who need to access the older templateMagento.gitignoreto the v2 formatSupporting specialized frameworks
A request to add
Vue.jswas added in #2809 but the template itself is just four rules:This instead could live under
community/JavaScript/Vue.gitignoreand look like this:As a first pass expanding on this idea, I've been able to resolve 30+ outstanding PRs (some overlap because they propose the same change)
TODO