[firebase_auth] Ability to choose between sign-in or link on auto verification of phone number on Android by cqhchan · Pull Request #973 · flutter/plugins

cqhchan · 2018-12-08T10:51:13Z

Fixed Android Link with credentials bug.
Added in ability to choose between sign-in or link on auto verification of phone number

- Added in ability to choose between sign-in or link on auto verification of phone number

ened · 2018-12-08T13:01:27Z

packages/firebase_auth/lib/src/firebase_auth.dart

+      @required PhoneVerificationFailed verificationFailed,
+      @required PhoneCodeSent codeSent,
+      @required PhoneCodeAutoRetrievalTimeout codeAutoRetrievalTimeout,
+      bool linkCredentials = false}) async {


Could you please add back the comma (,) at the end of the array setup and reformat?

ened · 2018-12-08T13:01:59Z

.../firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java

+                          if (task.isSuccessful()) {
+                            Map<String, Object> arguments = new HashMap<>();
+                            arguments.put("handle", handle);
+                            channel.invokeMethod("phoneVerificationCompleted", arguments);


Could the 2 onComplete handlers be merged?

Hi @ened completed the requested changes

.../firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java

…pleteListener

cqhchan · 2018-12-10T03:49:04Z

@ened completed the requested changes

cqhchan · 2019-02-28T09:27:10Z

@tolotrasamuel

firebase_auth: git: url: git://github.com/cqhchan/plugins.git path: packages/firebase_auth

Insert this into pubspec.yaml to use it.

https://github.com/cqhchan/plugins

This makes use of credentials implementation in #928
I fixed a few bugs with their implementation and added a bool value in
Future<void> verifyPhoneNumber(...)
to allow you to differentiate between verifyPhoneNumber for Login or For linking credentials with existing account. This addition bool value only affects specific android devices where they have auto verification.

collinjackson · 2019-03-22T12:49:53Z

Thanks for the contribution!

We've fixed the linkWithCredential issue (#1333).

I'd love to get the other parts of your change, but I think we need an iOS implementation. Before we land this I'd ideally like to figure out how to write integration tests for phone auth so that we know the functionality is working on all platforms.

collinjackson · 2019-04-09T01:37:51Z

@cqhchan -- Please let me know if you'd like to implement the iOS side of the pull request or if you want to abandon this PR. Thanks!

cqhchan · 2019-04-09T05:45:09Z

hi @collinjackson , Im not too sure what IOS side u are referring to. The bug only appeared in Android. Regarding the additional feature to enable auto phone number verification, again it is an Android only feature in selected Android phones that support it

collinjackson

OK, you're right -- this is an Android-only feature.

collinjackson · 2019-04-09T19:36:58Z

.../firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java

+
+    @Override
+    public void onComplete(@NonNull Task<AuthResult> task) {
+      if (task.isSuccessful()) {


It seems like we should report errors back to the Dart side rather than swallowing them

creativecreatorormaybenot · 2019-04-10T18:01:35Z

@collinjackson Is this going to be merged soon then? (considering the comment)

collinjackson · 2019-05-06T13:46:48Z

The API design in #1568 seems preferable to me, so I'm closing this one.

- Fixed Android Link with credentials bug.

79409ab

- Added in ability to choose between sign-in or link on auto verification of phone number

googlebot added the cla: yes label Dec 8, 2018

ened reviewed Dec 8, 2018

View reviewed changes

cqhchan added 3 commits December 8, 2018 22:50

- Merged onVerificationComplete handler to single PhoneVerficationCom…

e2e9d7b

…pleteListener

Added Comma and Reformatted

ad08370

Fixed Error

157dc20

This was referenced Jan 18, 2019

[firebase_auth]Fixed linkWithCredential implementation for Android #1077

Closed

[firebase_auth]Fixing exception on Android when linking phone number to email/password account #1069

Closed

cyanglaz changed the title ~~With issue with firebase_auth linkWithCredentials on Android~~ [firebase_auth]With issue with firebase_auth linkWithCredentials on Android Feb 22, 2019

cyanglaz added flutterfire bugfix labels Feb 22, 2019

kroikie self-assigned this Mar 21, 2019

collinjackson self-requested a review March 22, 2019 12:40

kroikie assigned collinjackson and unassigned kroikie Mar 25, 2019

collinjackson added 2 commits April 9, 2019 12:28

Merge remote-tracking branch 'origin/master' into fix_firebase_auth

fdd979a

Fix merge damage

dfc528f

collinjackson changed the title ~~[firebase_auth]With issue with firebase_auth linkWithCredentials on Android~~ [firebase_auth] Ability to choose between sign-in or link on auto verification of phone number Apr 9, 2019

collinjackson changed the title ~~[firebase_auth] Ability to choose between sign-in or link on auto verification of phone number~~ [firebase_auth] Ability to choose between sign-in or link on auto verification of phone number on Android Apr 9, 2019

collinjackson reviewed Apr 9, 2019

View reviewed changes

creativecreatorormaybenot mentioned this pull request May 5, 2019

[firebase_auth] Removed automatic signing in behaviour when signing in with phone auth. #1568

Merged

collinjackson closed this May 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[firebase_auth] Ability to choose between sign-in or link on auto verification of phone number on Android#973

[firebase_auth] Ability to choose between sign-in or link on auto verification of phone number on Android#973
cqhchan wants to merge 6 commits intoflutter:masterfrom
cqhchan:fix_firebase_auth

cqhchan commented Dec 8, 2018

Uh oh!

ened Dec 8, 2018

Uh oh!

ened Dec 8, 2018

Uh oh!

cqhchan Dec 14, 2018

Uh oh!

Uh oh!

cqhchan commented Dec 10, 2018

Uh oh!

cqhchan commented Feb 28, 2019

Uh oh!

collinjackson commented Mar 22, 2019

Uh oh!

collinjackson commented Apr 9, 2019

Uh oh!

cqhchan commented Apr 9, 2019

Uh oh!

collinjackson left a comment

Uh oh!

collinjackson Apr 9, 2019

Uh oh!

creativecreatorormaybenot commented Apr 10, 2019

Uh oh!

collinjackson commented May 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

cqhchan commented Dec 8, 2018

Uh oh!

ened Dec 8, 2018

Choose a reason for hiding this comment

Uh oh!

ened Dec 8, 2018

Choose a reason for hiding this comment

Uh oh!

cqhchan Dec 14, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cqhchan commented Dec 10, 2018

Uh oh!

cqhchan commented Feb 28, 2019

Uh oh!

collinjackson commented Mar 22, 2019

Uh oh!

collinjackson commented Apr 9, 2019

Uh oh!

cqhchan commented Apr 9, 2019

Uh oh!

collinjackson left a comment

Choose a reason for hiding this comment

Uh oh!

collinjackson Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

creativecreatorormaybenot commented Apr 10, 2019

Uh oh!

collinjackson commented May 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants