Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth]Fixing exception on Android when linking phone number to email/password account#1069

Closed
kika wants to merge 2 commits intoflutter:masterfrom
kika:firebase-auth
Closed

[firebase_auth]Fixing exception on Android when linking phone number to email/password account#1069
kika wants to merge 2 commits intoflutter:masterfrom
kika:firebase-auth

Conversation

@kika
Copy link

@kika kika commented Jan 12, 2019

Fix for flutter/flutter#26477

For completeness this one is also needed: b26b272

@cqhchan
Copy link

cqhchan commented Jan 18, 2019

Hey, I saw this and you need to include the case on android where phone auth takes place without sending an sms. I had had a fix earlier in #973 to solve that issue as well

@kika
Copy link
Author

kika commented Jan 18, 2019

@cqhchan I'd love to, but for that, I believe I need a real Android device with SIM card and active service and I don't have any physical Android device around. Only emulator.

@cyanglaz cyanglaz changed the title Fixing exception on Android when linking phone number to email/password account [firebase_auth]Fixing exception on Android when linking phone number to email/password account Feb 22, 2019
@davydany
Copy link

Flutter team, please review and merge this code. This is blocking so many folks!

@dev-mush
Copy link

this is blocking my team as well, why it's not being addressed?

@davydany
Copy link

If anyone is blocked by this, please use the following in your pubspec.yaml, and comment out whatever you have for firebase_auth.

...

  firebase_auth:
    git:
      url: https://github.com/aeroxis/plugins.git
      path: packages/firebase_auth
      ref: firebase-auth-phone-bug-fix
...

This is the work that @kika already did but with the latest version as of 03/18/2019.

The pull request shows the changes I made: #1358

@collinjackson
Copy link
Contributor

It looks like this was fixed in #1333, but if I'm mistaken please let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants