This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] fixes Android linkWithCredential#1333
Merged
collinjackson merged 5 commits intoflutter:masterfrom Mar 22, 2019
Merged
[firebase_auth] fixes Android linkWithCredential#1333collinjackson merged 5 commits intoflutter:masterfrom
collinjackson merged 5 commits intoflutter:masterfrom
Conversation
Contributor
|
Linter wants you to reformat this. I think this looks good but it'd be best to have @mklim @collinjackson @kroikie or @amirh to check it out as they're more involved in these at the moment. |
Contributor
|
I would ideally like to have a regression test for this but I'm still figuring out the best way to do integration testing for this particular API. I don't want to hold back the fix so I'll land it as is. |
collinjackson
approved these changes
Mar 22, 2019
collinjackson
changed the title
This was referenced Mar 22, 2019
This was referenced Apr 9, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method call has been incorrect and needed an update to use the correct parameters as passed from the Dart side.
Tests are needed soon..
@dnfield Could you help to review, please?