This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] Removed automatic signing in behaviour when signing in with phone auth.#1568
Merged
collinjackson merged 14 commits intoflutter:masterfrom May 6, 2019
Merged
Conversation
Contributor
Author
|
I think this is a very small and serious thing to address as the SDK is supposed to behave similarly to all the possible ways to sign in. Also, this PR will break the previous user's application as it will not sign in automatically and the user has to |
Contributor
|
This actually seems better than #973. |
collinjackson
approved these changes
May 6, 2019
Contributor
collinjackson
left a comment
collinjackson
left a comment
There was a problem hiding this comment.
Thanks for the PR. I made a few changes to reduce the public API surface area of this change.
| }); | ||
| } | ||
|
|
||
| static AuthCredential getCredentialFromObject({ |
Contributor
There was a problem hiding this comment.
I'm removing this constructor from the public API.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…n with phone auth. (flutter#1568) * Update phone auth on Android to avoid signing in the user automatically. * Remove nextHandle from public API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to issue flutter/flutter#22304.
The plugin demands auth credential while logging in with facebook, google, emailPassword. Which gives developer the option to create new account with it or link it to the existing user. But the phone auth used to behave differently, it directly used to sign in and create new user which was preventing developers to link it to the existing user. Thus this PR removes that behaviour and gives ability to extract phone auth cred and use it as required.
I have used Gson to parse and send the PhoneAuthCredential to the dart side. Not sure if its a good idea, suggestions are welcomed.
Note: This automatic signing in for phone auth was not enabled on the IOS side thus no changes have been made to the IOS code, let me know if I am missing something here.
To use this PR, copy the following lines to your pubspec.yaml file.