Linking anonymous account to phone number#809
Linking anonymous account to phone number#809creativecreatorormaybenot wants to merge 15 commits intoflutter:masterfrom creativecreatorormaybenot:firebase-auth
Conversation
|
This also workarounds flutter/flutter#22304, as I can authenticate user with email first. |
|
I can confirm that this is now fully working as expected. |
|
@creativecreatorormaybenot Does this pr add a feature to send a verification code (without signing in with the phone number flutter/flutter#22304)? |
|
@kdy1 This is what |
|
This looks good, except for one teensy formatting nit, if you don't mind. Thanks for the contribution, and thanks especially for including a test with it! If you don't mind updating for the nit and resolving the branch conflict, we'll merge this after. Otherwise, we'll get it picked up eventually. |
|
I can take a look at this if conflicts are resolved |
|
This is now possible using |
|
Although this is possible using |
|
You're right @awazgyawali, see flutter/flutter#22304 |
|
Thus I have added a PR to fix this, can you look into it? Its a very simple one. #1568 |
This is lacking tests (although I do not know if they are required) and testing from my side. I am currently unable to test it because of this issue, but I figured that I might want to get some feedback already.
This pull request would resolve flutter/flutter#22491.