Skip to content

Use eth errors#207

Merged
whymarrh merged 2 commits into1.xfrom
use-eth-errors
Feb 26, 2020
Merged

Use eth errors#207
whymarrh merged 2 commits into1.xfrom
use-eth-errors

Conversation

@rickycodes
Copy link
Contributor

re-applying #200 onto 1.x

@whymarrh whymarrh self-requested a review February 26, 2020 22:20
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit d06fba6 into 1.x Feb 26, 2020
@whymarrh whymarrh deleted the use-eth-errors branch February 26, 2020 22:29
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
`@metamask/network-controller` now contains an `RpcService` class. Using
this class not only allows us to remove a lot of code from this package,
as it incorporates the vast majority of logic contained in
`createFetchMiddleware`, including the retry logic, but it also allows
us to use the circuit breaker pattern and the exponential backoff
pattern to prevent too many retries if the network is unreliable, and
then automatically cut over to a failover node when the network truly
goes down.

Closes #356.
Closes #207.
Closes #209.
Closes #211.
Closes #166.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants