Skip to content

Add project ID to all Infura endpoints#202

Merged
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:infura-v3
Feb 25, 2020
Merged

Add project ID to all Infura endpoints#202
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:infura-v3

Conversation

@whymarrh
Copy link
Contributor

This PR adds the existing project ID to all Infura v3 endpoints.

@codecov-io
Copy link

Codecov Report

Merging #202 into develop will increase coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #202      +/-   ##
=========================================
+ Coverage    98.48%   100%   +1.51%     
=========================================
  Files           23     23              
  Lines         1519   1519              
  Branches       211    211              
=========================================
+ Hits          1496   1519      +23     
+ Misses          21      0      -21     
+ Partials         2      0       -2
Impacted Files Coverage Δ
src/assets/AssetsContractController.ts 100% <0%> (+1.44%) ⬆️
src/transaction/TransactionController.ts 100% <0%> (+2.83%) ⬆️
src/assets/AccountTrackerController.ts 100% <0%> (+5%) ⬆️
src/assets/AssetsController.ts 100% <0%> (+5.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed601b6...92f952d. Read the comment docs.

@whymarrh whymarrh mentioned this pull request Feb 25, 2020
@whymarrh whymarrh marked this pull request as ready for review February 25, 2020 14:52
@whymarrh
Copy link
Contributor Author

  1. These are all tests
  2. This project ID was already in use

Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suites: 23 passed, 23 total
Tests:       317 passed, 317 total
Snapshots:   0 total
Time:        6.871s
Ran all test suites.
Done in 7.35s.

😍

@whymarrh whymarrh merged commit 95c42c1 into MetaMask:develop Feb 25, 2020
@whymarrh whymarrh deleted the infura-v3 branch February 25, 2020 15:48
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
* Add Shared Libraries team in codeowners file
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants