Merged
Conversation
Contributor
|
This might be aided by MetaMask/rpc-errors#9 |
rickycodes
force-pushed
the
use-eth-json-rpc-errors
branch
from
741b0c6 to
5e0d6d9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #200 +/- ##
======================================
Coverage 100% 100%
======================================
Files 23 23
Lines 1519 1520 +1
Branches 211 211
======================================
+ Hits 1519 1520 +1
Continue to review full report at Codecov.
|
rickycodes
force-pushed
the
use-eth-json-rpc-errors
branch
from
5e0d6d9 to
1baf521
Compare
rickycodes
force-pushed
the
use-eth-json-rpc-errors
branch
from
1baf521 to
5365519
Compare
Codecov Report
@@ Coverage Diff @@
## develop #200 +/- ##
======================================
Coverage 100% 100%
======================================
Files 23 23
Lines 1519 1520 +1
Branches 211 211
======================================
+ Hits 1519 1520 +1
Continue to review full report at Codecov.
|
rekmarks
reviewed
Feb 25, 2020
| case 'failed': | ||
| return reject(new Error(meta.error!.message)); | ||
| return reject(ethErrors.rpc.internal(meta.error!.message)); | ||
| /* istanbul ignore next */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: MetaMask/metamask-mobile#1314
I've confirmed that after this we get functionality similar to the extension in the mobile app:
todo