Prevent ApprovalController counting mismatch#356
Merged
Conversation
The `ApprovalController` was not great at counting. If you tried to delete an approval that didn't exist, or if you tried to add an approval that already existed, it would miscount the current number of pending approvals. Validation was in place already to prevent both scenarios, so in practice this shouldn't be possible without calling private functions. But still, preventing it entirely was trivial, so here it is.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `ApprovalController` was not great at counting. If you tried to delete an approval that didn't exist, or if you tried to add an approval that already existed, it would miscount the current number of pending approvals. Validation was in place already to prevent both scenarios, so in practice this shouldn't be possible without calling private functions. But still, preventing it entirely was trivial, so here it is.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `ApprovalController` was not great at counting. If you tried to delete an approval that didn't exist, or if you tried to add an approval that already existed, it would miscount the current number of pending approvals. Validation was in place already to prevent both scenarios, so in practice this shouldn't be possible without calling private functions. But still, preventing it entirely was trivial, so here it is.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
`@metamask/network-controller` now contains an `RpcService` class. Using this class not only allows us to remove a lot of code from this package, as it incorporates the vast majority of logic contained in `createFetchMiddleware`, including the retry logic, but it also allows us to use the circuit breaker pattern and the exponential backoff pattern to prevent too many retries if the network is unreliable, and then automatically cut over to a failover node when the network truly goes down. Closes #356. Closes #207. Closes #209. Closes #211. Closes #166.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ApprovalControllerwas not great at counting. If you tried to delete an approval that didn't exist, or if you tried to add an approval that already existed, it would miscount the current number of pending approvals.Validation was in place already to prevent both scenarios, so in practice this shouldn't be possible without calling private functions. But still, preventing it entirely was trivial, so here it is.