Skip to content

Fixing a11y issues.#55

Closed
jugshaurya wants to merge 1 commit intoreact-native-elements:masterfrom
jugshaurya:bugfix/fixing-accessibilities
Closed

Fixing a11y issues.#55
jugshaurya wants to merge 1 commit intoreact-native-elements:masterfrom
jugshaurya:bugfix/fixing-accessibilities

Conversation

@jugshaurya
Copy link
Contributor

This PR will fix up issue #54

Solution

  • adding span with role "img"
  • adding alt attribute to img tags
  • adding rel="noopener noreferrer".

@netlify
Copy link

netlify bot commented Mar 13, 2021

Deploy preview for rne-playground ready!

Built with commit fc554bf

https://deploy-preview-55--rne-playground.netlify.app

@jugshaurya
Copy link
Contributor Author

@pranshuchittora, please review

@Uyadav207
Copy link
Contributor

@jugshaurya, I have been working on the issue for 2 two days, kindly find some other. Thanks.

please have a look at #47

@pranshuchittora
Copy link
Member

Already fixed in a PR before this.
Duplicate #47

Feel free to reopen if there's no overlap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants