Skip to content

Fixing a11y issues. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jugshaurya wants to merge 1 commit into from
Closed

Fixing a11y issues. #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/components/Footer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,25 @@ function Footer() {
<Grid container spacing={5} justify="center">
<Grid item xs={12} md={6} lg={4}>
<Typography variant="h4" style={{ marginBottom: 10 }}>
Playground 🚀
Playground{" "}
<span role="img" aria-labelledby="rocket-emoji">
🚀
</span>
</Typography>

<Divider />

<a
href="https://github.com/react-native-elements/playground"
target="_blank"
>
rel="noopener noreferrer">
<Typography>GitHub Repositoy</Typography>
</a>

<a href="https://reactnativeelements.com/" target="_blank">
<a
href="https://reactnativeelements.com/"
target="_blank"
rel="noopener noreferrer">
<Typography>Official Docs</Typography>
</a>
<br />
Expand All @@ -46,16 +52,16 @@ function Footer() {
<a
href="https://github.com/react-native-elements/react-native-elements/"
target="_blank"
>
rel="noopener noreferrer">
<Typography variant="h6">React Native Elements</Typography>
<Typography
variant="subtitle1"
className={styles.footer_product_info}
>
className={styles.footer_product_info}>
Cross-Platform React Native UI Toolkit
</Typography>

<img
alt="react-native-elements"
src={require("../../assets/RNE_Logo.png")}
className={styles.footer_product_img}
/>
Expand Down
32 changes: 17 additions & 15 deletions src/containers/Drawer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function ResponsiveDrawer(props) {
const [selectedIndex, setSelectedIndex] = React.useState(-1);

const handleDrawerToggle = (value) => {
if(value === false){
if (value === false) {
setMobileOpen(false);
} else {
setMobileOpen(true);
Expand All @@ -92,23 +92,26 @@ function ResponsiveDrawer(props) {
<div>
<div style={{ padding: "0.5rem" }}>
<Link to="/">
<Typography variant="h5">Playground 🚀</Typography>
<Typography variant="h5">
Playground{" "}
<span role="img" aria-labelledby="rocket-emoji">
🚀
</span>
</Typography>
</Link>
</div>
<List>
{Components_Index.map((elm, index) => (
<Link
key={elm.name}
to={elm.path}
onClick={() => handleDrawerToggle(false)}
>
onClick={() => handleDrawerToggle(false)}>
<ListItem
button
key={elm.name}
selected={selectedIndex === index}
onClick={(event) => handleListItemClick(event, index)}
className={classes.sideListItem}
>
className={classes.sideListItem}>
<ListItemText primary={elm.name} />
</ListItem>
</Link>
Expand All @@ -130,8 +133,7 @@ function ResponsiveDrawer(props) {
aria-label="open drawer"
edge="start"
onClick={handleDrawerToggle}
className={classes.menuButton}
>
className={classes.menuButton}>
<MenuIcon />
</IconButton>
<Link to="/">
Expand All @@ -140,15 +142,17 @@ function ResponsiveDrawer(props) {
</Typography>
</Link>
<div style={{ marginLeft: "auto" }}>
<a href="https://reactnativeelements.com/" target="_blank">
<a
href="https://reactnativeelements.com/"
target="_blank"
rel="noopener noreferrer">
<Button color="inherit">Docs</Button>
</a>
<IconButton
color="inherit"
rel="noopener noreferrer"
href="https://github.com/react-native-elements/react-native-elements"
target="_blank"
>
target="_blank">
<GitHub />
</IconButton>
</div>
Expand All @@ -168,8 +172,7 @@ function ResponsiveDrawer(props) {
}}
ModalProps={{
keepMounted: true, // Better open performance on mobile.
}}
>
}}>
{drawer}
</Drawer>
</Hidden>
Expand All @@ -179,8 +182,7 @@ function ResponsiveDrawer(props) {
paper: classes.drawerPaper,
}}
variant="permanent"
open
>
open>
{drawer}
</Drawer>
</Hidden>
Expand Down
17 changes: 10 additions & 7 deletions src/pages/home/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@ function HomePage() {
variant="h2"
style={{
fontSize: "calc(2rem + 6 * ((100vw - 320px) / 680))",
}}
>
}}>
Exploring possibilities
</Typography>
<Typography
variant="h6"
style={{ fontWeight: "200", fontStyle: "italic" }}
>
style={{ fontWeight: "200", fontStyle: "italic" }}>
with React Native Elements
</Typography>
</Grid>
Expand All @@ -33,7 +31,12 @@ function HomePage() {
<div style={{ width: "100%", textAlign: "center", marginBottom: "2rem" }}>
<Link to="/explore">
<Button variant="outlined" color="secondary">
<Typography variant="h6">Explore Now 🌇</Typography>
<Typography variant="h6">
Explore Now{" "}
<span role="img" aria-labelledby="sunset-over-building-emoji">
🌇
</span>
</Typography>
</Button>
</Link>
</div>
Expand All @@ -52,8 +55,7 @@ function HomePage() {
container
spacing={5}
justify="center"
style={{ justifyContent: "space-evenly" }}
>
style={{ justifyContent: "space-evenly" }}>
<Grid item xs={12} md={7} lg={6}>
<Typography variant="h5">Why?</Typography>
<Typography>
Expand Down Expand Up @@ -87,6 +89,7 @@ const FeatureCard = (props) => {
return (
<Paper style={{ padding: "14px 7px", height: "100%" }}>
<img
alt="art"
style={{
width: "70%",
minHeight: 250,
Expand Down