Skip to content

🔥 ( Hot-Fix )(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pranshuchittora merged 2 commits into from
Mar 19, 2021
Merged

🔥 ( Hot-Fix )(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) #47

pranshuchittora merged 2 commits into from
Mar 19, 2021

Conversation

@Uyadav207
Copy link
Contributor

@Uyadav207 Uyadav207 commented Mar 12, 2021

What kind of change does this PR introduce?

Did you add tests for your changes?

  • Tested the changes on the local machine.

If relevant, did you update the documentation?

  • Not required

Summary

Does this PR introduce a breaking change?

  • This PR can result in a breaking change, if least prioritized (includes changes in multiple file)

Other information

  • Attaching below the screenshots for the suggested changes and verification by @pranshuchittora

captured (2)

@netlify
Copy link

netlify bot commented Mar 12, 2021 •
edited
Loading

Deploy preview for rne-playground ready!

Built with commit 4213bde

https://deploy-preview-47--rne-playground.netlify.app

@Uyadav207 Uyadav207 changed the title Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) Hot-fix(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) Mar 12, 2021
@Uyadav207 Uyadav207 mentioned this pull request Mar 12, 2021
Closed
This was referenced Mar 13, 2021
Closed
Closed
Closed
Closed
@Uyadav207 Uyadav207 changed the title Hot-fix(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) 🔥 ( Hot-Fix )(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) Mar 16, 2021
pranshuchittora
pranshuchittora approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@pranshuchittora pranshuchittora merged commit 5128369 into react-native-elements:master Mar 19, 2021
@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 19, 2021

Thanks :)

ankushdutt pushed a commit to ankushdutt/playground that referenced this pull request Mar 20, 2021
@Uyadav207 @ankushdutt
🔥 ( Hot-Fix )(resolved-conflict): Rectification of code by removing a…
ac0f416 
…ll (jsx-A11y) warnings (Conflict Resolved) (react-native-elements#47)

* Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings

* hot-fix: Drawer component now closes on clicking playground icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranshuchittora pranshuchittora pranshuchittora approved these changes

+1 more reviewer

@tewarig tewarig tewarig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Uyadav207 @pranshuchittora @tewarig