Skip to content

Comments

NO-jIRA: move some operator crds to openshift/api#2030

Merged
deads2k merged 2 commits intoopenshift:masterfrom
deads2k:move-01-some-operator-CRDs
Sep 17, 2024
Merged

NO-jIRA: move some operator crds to openshift/api#2030
deads2k merged 2 commits intoopenshift:masterfrom
deads2k:move-01-some-operator-CRDs

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 16, 2024

  1. etcd
  2. kube-apiserver
  3. kube-controller-manager
  4. kube-scheduler
  5. openshift-apiserver
  6. openshift-controller-manager
  7. openshift-authentication

to come in other PRs, MCO stuff, image registry, network edge, storage.

/assign @JoelSpeed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 16, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@deads2k deads2k changed the title move some operator crds to openshift/api NO-jIRA: move some operator crds to openshift/api Sep 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2024
@openshift-ci-robot
Copy link

@deads2k: This pull request explicitly references no jira issue.

Details

In response to this:

  1. etcd
  2. kube-apiserver
  3. kube-controller-manager
  4. kube-scheduler
  5. openshift-apiserver
  6. openshift-controller-manager
  7. openshift-authentication

to come in other PRs, MCO stuff, image registry, network edge, storage.

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 16, 2024

/retest

@JoelSpeed
Copy link
Contributor

Change looks fine, and until all CRDs are deployed from this repo, the awkward duplication does save us some E2E cycles, so, lets keep this approach for now and once we are complete, we can remove the duplication

/lgtm

/hold

Holding in case this needs to be released in a particular time window

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k force-pushed the move-01-some-operator-CRDs branch from 1a434c7 to 3c344eb Compare September 17, 2024 14:43
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

New changes are detected. LGTM label has been removed.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 17, 2024

clusterbot cluster installed correctly. Merging and will get the others later to help the nightly image build likelihood.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409171909.p0.g1d61618.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants