Skip to content

NO-JIRA: move storage CRDs to openshift/api#2032

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
bertinatto:move-csi-crds
Sep 19, 2024
Merged

NO-JIRA: move storage CRDs to openshift/api#2032
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
bertinatto:move-csi-crds

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Sep 17, 2024

This is a follow-up to #2030.

This makes the promotion of featuregates more atomic, as the CRD schema changes in the same PR that changes the feature.

This will prevent changes like this when adding new TechPreview fields to ClusterCSIDriver CRDs.

CC @openshift/storage

@openshift-ci-robot
Copy link

@bertinatto: This pull request explicitly references no jira issue.

Details

In response to this:

This is a follow-up to #2030.

/hold
Until all PRs associated with #2030 are merged and we're sure this works.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2024
@bertinatto bertinatto changed the title NO-jIRA: move storage CRDs to openshift/api NO-JIRA: move storage CRDs to openshift/api Sep 17, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

Hello @bertinatto! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2024
@deads2k
Copy link
Contributor

deads2k commented Sep 18, 2024

/lgtm
/hold

Due to some out of sync-ness, the order needs to be

  1. update https://github.com/openshift/cluster-storage-operator with latest openshift/api and merge
  2. then re-test this PR for green and merge (notice verify is red now)
  3. then, shortly after merge https://github.com/openshift/cluster-storage-operator/pull/505/files.

But the change here lgtm.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@bertinatto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
@deads2k
Copy link
Contributor

deads2k commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8f6ded4 and 2 for PR HEAD de692e9 in total

@bertinatto
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2669d1e into openshift:master Sep 19, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409200008.p0.g2669d1e.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants