Skip to content

API-1835: make operator generations behave as a map list type#2029

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
deads2k:apply-01-fix-generations
Sep 18, 2024
Merged

API-1835: make operator generations behave as a map list type#2029
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
deads2k:apply-01-fix-generations

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 16, 2024

This will allow coordination between different observers watching the various generations. For instance, what if you want to track different deployments.

Need to vendor into storage, auth, and openshift-apiserver to prove it works ok.

/assign @bertinatto @p0lyn0mial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@deads2k deads2k changed the title make operator generations behave as a map list type API-1835: make operator generations behave as a map list type Sep 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

Details

In response to this:

This will allow coordination between different observers watching the various generations. For instance, what if you want to track different deployments.

Need to vendor into storage, auth, and openshift-apiserver to prove it works ok.

/assign @bertinatto @p0lyn0mial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 17, 2024

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Sep 17, 2024

/hold

need all PRs associated with #2030 to merge first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Sep 17, 2024

/hold cancel

manually tested for storage operator. Most library-go operators now direct from api repo.

/test all

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@deads2k deads2k force-pushed the apply-01-fix-generations branch from f0baae9 to 8abc53a Compare September 17, 2024 21:04
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1d61618 and 2 for PR HEAD 8abc53a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 07bccfd into openshift:master Sep 18, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409180510.p0.g07bccfd.assembly.stream.el9.
All builds following this will include this PR.

bertinatto added a commit to bertinatto/cluster-storage-operator that referenced this pull request Sep 18, 2024
@p0lyn0mial
Copy link
Contributor

as changing the type changes the merge strategy

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants