Skip to content

[4.15] OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions#1767

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
dobsonj:OCPBUGS-29196-4.15
Feb 28, 2024
Merged

[4.15] OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions#1767
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
dobsonj:OCPBUGS-29196-4.15

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Feb 12, 2024

Cherry-pick 72a9eae into release-4.15
/cc @openshift/storage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Cherry-pick 72a9eae into release-4.15
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

Hello @dobsonj! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Feb 12, 2024

/jira cherrypick OCPBUGS-29196

@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-29196 has been cloned as Jira Issue OCPBUGS-29370. Will retitle bug to link to clone.
/retitle OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions

Details

In response to this:

/jira cherrypick OCPBUGS-29196

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions Feb 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 12, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-29370, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29196 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry-pick 72a9eae into release-4.15
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj dobsonj changed the title OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions [4.15] OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions Feb 12, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Feb 12, 2024

/assign @JoelSpeed
for review and backport-risk-assessed

@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@dobsonj
Copy link
Member Author

dobsonj commented Feb 14, 2024

@JoelSpeed can you try again to tag it? it didn't take for some reason.

@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@Phaow
Copy link
Contributor

Phaow commented Feb 19, 2024

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xingxingxia
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2024
@Phaow
Copy link
Contributor

Phaow commented Feb 19, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@Phaow: This pull request references Jira Issue OCPBUGS-29370, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29196 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29196 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Phaow February 19, 2024 06:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4511c79 into openshift:release-4.15 Feb 28, 2024
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-29370: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29370 has been moved to the MODIFIED state.

Details

In response to this:

Cherry-pick 72a9eae into release-4.15
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202402280237.p0.g4511c79.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@dobsonj
Copy link
Member Author

dobsonj commented Feb 28, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot

@dobsonj: new pull request created: #1779

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-01-184903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.