Skip to content

[4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions#1779

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-1767-to-release-4.14
Mar 4, 2024
Merged

[4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions#1779
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-1767-to-release-4.14

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1767

/assign dobsonj

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29370 has been cloned as Jira Issue OCPBUGS-30054. Will retitle bug to link to clone.
/retitle [release-4.14] [4.15] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions

Details

In response to this:

This is an automated cherry-pick of #1767

/assign dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] [4.15] OCPBUGS-29370: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions [release-4.14] [4.15] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions Feb 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 28, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30054, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29370 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1767

/assign dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 28, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2024
@dobsonj
Copy link
Member

dobsonj commented Feb 28, 2024

/retitle [4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
/jira refresh

@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30054, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29370 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/retitle [4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] [4.15] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions [4.14] OCPBUGS-30054: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions Feb 28, 2024
@openshift-ci openshift-ci bot requested review from knobunc and mfojtik February 28, 2024 18:19
@dobsonj
Copy link
Member

dobsonj commented Feb 28, 2024

/lgtm
/cc @Phaow

/assign @JoelSpeed
for approve and backport-risk-assessed

@openshift-ci openshift-ci bot requested a review from Phaow February 28, 2024 18:21
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@dobsonj
Copy link
Member

dobsonj commented Feb 28, 2024

/assign @xingxingxia
for cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xingxingxia
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 29, 2024
@Phaow
Copy link
Contributor

Phaow commented Mar 4, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 4, 2024
@openshift-ci-robot
Copy link

@Phaow: This pull request references Jira Issue OCPBUGS-30054, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29370 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29370 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3e8192a into openshift:release-4.14 Mar 4, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30054: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30054 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1767

/assign dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-03-08-015514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants