OCPBUGS-29196: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions

[ungureanuvladvictor]

When trying to set up KMS encryption in us-isob-east-1 region validation fails on the custom resource.

[openshift-ci]

Hello @ungureanuvladvictor! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Hi @ungureanuvladvictor. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/ok-to-test

[dobsonj]

/assign @patrickdillon @JoelSpeed
to review the API change

[dobsonj]

/retitle OCPBUGS-29196: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
see also: current list of aws partitions

[openshift-ci-robot]

@ungureanuvladvictor: This pull request references Jira Issue OCPBUGS-29196, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When trying to set up KMS encryption in us-isob-east-1 region validation fails on the custom resource.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-29196, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dobsonj]

Looks okay to me, but needs a rebase.
/retest

[ungureanuvladvictor]

@dobsonj just rebased, pls take a look

[dobsonj]

Thanks @ungureanuvladvictor !
/lgtm
needs approval from @JoelSpeed to merge

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed, ungureanuvladvictor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@ungureanuvladvictor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ungureanuvladvictor: Jira Issue OCPBUGS-29196: All pull requests linked via external trackers have merged:

• openshift/api#1740

Jira Issue OCPBUGS-29196 has been moved to the MODIFIED state.

Details

In response to this:

When trying to set up KMS encryption in us-isob-east-1 region validation fails on the custom resource.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402121340.p0.g04ea389.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

[ungureanuvladvictor]

@dobsonj -- I was looking at the CSI drivers repo and not sure how you folks want to proceed with bumping this in the https://github.com/openshift/aws-ebs-csi-driver-operator + https://github.com/openshift/csi-operator. For the csi-operator I think it's p easy because the repo is active, but for the aws-ebs-csi-driver I don't have insight into how backports work there.

Let me know if I can help in any way here.

[dobsonj]

@ungureanuvladvictor The ClusterCSIDriver CRD is deployed by cluster-storage-operator for all platforms, so we just have to bump openshift/api in that repo to vendor the change. I just opened a PR for this: openshift/cluster-storage-operator#455

And we can start the backport for this API change to 4.15 in the mean time (there is a bot for this).
/cherry-pick release-4.15

[openshift-cherrypick-robot]

@dobsonj: #1740 failed to apply on top of branch "release-4.15":

Applying: Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
Using index info to reconstruct a base tree...
M	operator/v1/0000_90_cluster_csi_driver_01_config.crd.yaml
M	operator/v1/types_csi_cluster_driver.go
Falling back to patching base and 3-way merge...
Auto-merging operator/v1/types_csi_cluster_driver.go
Auto-merging operator/v1/0000_90_cluster_csi_driver_01_config.crd.yaml
CONFLICT (content): Merge conflict in operator/v1/0000_90_cluster_csi_driver_01_config.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update AWSCSIDriverConfigSpec fields validation to accept all current AWS partitions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

@ungureanuvladvictor The ClusterCSIDriver CRD is deployed by cluster-storage-operator for all platforms, so we just have to bump openshift/api in that repo to vendor the change. I just opened a PR for this: openshift/cluster-storage-operator#455

And we can start the backport for this API change to 4.15 in the mean time.
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

So much for the cherrypick bot
/jira help

[dobsonj]

/cherry-pick help

[openshift-cherrypick-robot]

@dobsonj: cannot checkout help: error checking out "help": exit status 1 error: pathspec 'help' did not match any file(s) known to git

Details

In response to this:

/cherry-pick help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

API backport to 4.15: #1767

[ungureanuvladvictor]

@dobsonj -- how far back do you folks usually backport ?

[dobsonj]

@dobsonj -- how far back do you folks usually backport ?

To fully supported releases, which right now means 4.14.
https://access.redhat.com/support/policy/updates/openshift/

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806