migrate code from googleapis/nodejs-datastore#7263
Merged
Conversation
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4dafeee7-014d-47f6-a950-0e8b4e9c606e/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 345596855 Source-Link: googleapis/googleapis@d189e87
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/cacd5a12-e156-415f-94a2-533984f6802a/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0e11e365-f1b7-4b92-a9c3-48fa670eb1a0/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@57c23fa
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b97795fd-83e4-446d-82df-a81e380dba2c/targets - [ ] To automatically regenerate this PR, check this box.
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7dafd97e-012a-40d8-83de-75f08c081431/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@318e351
Just a simple documentation fix for the `Database` instances section. #### Before:  #### After:  --- Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-datastore/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [X] Appropriate docs were updated (if necessary) --- Fixes #793. 🦕
* chore: synth * chore: run npx compileProtos src * chore: npm run fix
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
🤖 I have created a release \*beep\* \*boop\* --- ## [6.4.0](https://github.com/googleapis/nodejs-datastore/compare/v6.3.1...v6.4.0) (2021-04-29) ### Features * Add createIndex, deleteIndex protos ([#797](https://github.com/googleapis/nodejs-datastore/issues/797)) ([3ff1f51](https://github.com/googleapis/nodejs-datastore/commit/3ff1f51f19297db94a370ec3fc9130f36e25ea70)) ### Bug Fixes * **deps:** update dependency sinon to v10 ([#810](https://github.com/googleapis/nodejs-datastore/issues/810)) ([267992f](https://github.com/googleapis/nodejs-datastore/commit/267992f4f1523fc5038715b009ebc697c5ca8255)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/cff9d817-e273-40bd-93c2-641247ec10e0/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) PiperOrigin-RevId: 361273630 Source-Link: googleapis/googleapis@5477122 PiperOrigin-RevId: 359094122 Source-Link: googleapis/googleapis@cc4a856
* chore: migrate to owl bot * chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b * chore: run the post processor * 🦉 Updates from OwlBot * chore: update post processor docker image * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix: Report warning on `.github/workflows/ci.yaml` Not all files in `.github/workflows` are managed, only `ci.yaml`. Related false-positive: googleapis/repo-automation-bots#1952 (comment) * fix: Report warning on `.github/workflows/ci.yaml` Not all files in `.github/workflows` are managed, only `ci.yaml`. Source-Link: googleapis/synthtool@2430f8d Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:14aaee566d6fc07716bb92da416195156e47a4777e7d1cd2bb3e28c46fe30fe2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
VERSION is used in @google-cloud/cloud-rad to publish ref docs for a particular version. Pass VERSION in via Stubby or Fusion. Source-Link: googleapis/synthtool@740366b Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:bbdd52de226c00df3356cdf25460397b429ab49552becca645adbc412f6a4ed5
* build: add auto-approve to Node libraries Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Link: googleapis/synthtool@5cae043 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:65aa68f2242c172345d7c1e780bced839bfdc344955d6aa460aa63b4481d93e5
🤖 I have created a release \*beep\* \*boop\* --- ### [6.4.1](https://github.com/googleapis/nodejs-datastore/compare/v6.4.0...v6.4.1) (2021-06-10) ### Bug Fixes * **deps:** require google-gax v2.12.0 ([#825](https://github.com/googleapis/nodejs-datastore/issues/825)) ([0dee08a](https://github.com/googleapis/nodejs-datastore/commit/0dee08a912620c114ddfcf38a1d0636893f6f15a)) * **deps:** update dependency sinon to v11 ([#832](https://github.com/googleapis/nodejs-datastore/issues/832)) ([d32610c](https://github.com/googleapis/nodejs-datastore/commit/d32610cdbe08151effc1a8d4b74540e68cbf4012)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Source-Link: googleapis/synthtool@41ccd8c Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:c9c7828c165b1985579098978877935ee52dda2b1b538087514fd24fa2443e7a
* chore: create flakybot.yaml This will instruct flakybot to apply priority: p2 label to its issues. * Update flakybot.yaml
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0 Committer: @miraleung PiperOrigin-RevId: 380641501 Source-Link: googleapis/googleapis@076f7e9 Source-Link: googleapis/googleapis-gen@27e4c88
🤖 I have created a release \*beep\* \*boop\* --- ### [6.4.2](https://github.com/googleapis/nodejs-datastore/compare/v6.4.1...v6.4.2) (2021-06-23) ### Bug Fixes * make request optional in all cases ([#843](https://github.com/googleapis/nodejs-datastore/issues/843)) ([d025627](https://github.com/googleapis/nodejs-datastore/commit/d0256278d1003a789c8b9ca082f923c5999b3257)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…scription (#1345) * Add descriptions for some query parameters * Eliminate the extra space * Add a description to all the alias parameters * Add documentation for property parameters * Add descriptions for the aggregation argument * Add property params to these objects * Add descriptions for data types * Fix the broken links * Add documentation for the addExcludeFromIndexes * Buffer description * Add a description for entity filters * Add parameters documentation for the `and` and `or * Add descriptions for the filter object * Add some parameter documentation for the client * Parameter for prepareGaxRequest_ * Add documentation to a few of the helper functions * Add more documentation for txn and request params * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Kim <kevkim@google.com>
* This test makes a call to the mock server This will be useful for debugging grpc issues. * Now the test works with the mock server in repo This mock server will be super useful for ensuring that the right data gets transmitted in private preview so that we can confirm the client library is working correctly. * Delete js file We use the ts file instead. * Add a README and guiding steps inline * Simplify the instructions * minor corrections * Resolve linting issues * Add headers for new code * Skip a mock server test
* Initialize gax stream * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Keep the type on this variable * Downgrade promisify --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix(doc): Fix param descriptions for filters * fix formatting --------- Co-authored-by: Kevin Kim <kevkim@google.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
* feat: New PropertyMask field which allows partial commits, lookups, and query results PiperOrigin-RevId: 635449160 Source-Link: googleapis/googleapis@dde0ec1 Source-Link: googleapis/googleapis-gen@8caa60d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGNhYTYwZDlhZWE4Mjk2NGExOWNkZjhmYWY5MTM4NDkxMWRiOGJkZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: remove redundant gRPC service config file feat: specify retry configuration PiperOrigin-RevId: 712493958 Source-Link: googleapis/googleapis@29aea41 Source-Link: googleapis/googleapis-gen@04bcbab Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRiY2JhYjQ1MDU5ODllOTg0YjE0MDNkNDM4ZmZmYzAzMTIxNDRhZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: paging changes for bigquery fix: add x-goog-request params to headers for LRO-polling methods fix: remove extra protos in ESM & capture ESM in headers docs: update comments for a Nodejs stream object PiperOrigin-RevId: 721038181 Source-Link: googleapis/googleapis@331a41a Source-Link: googleapis/googleapis-gen@e81b4c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTgxYjRjNWI1MjA4ODk1ZjY2M2EyNDA0ODYxNWE1OWQ1NjM2ZjQxNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: fix typings for headers in generator PiperOrigin-RevId: 723181578 Source-Link: googleapis/googleapis@c7b69f4 Source-Link: googleapis/googleapis-gen@d1bc1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDFiYzFhY2Q3NDI5NjQyMmE1Y2I2ZTBjNDAxNmM4YzQ4ZTk5ODUzOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: finalize fixing typings for headers in generator PiperOrigin-RevId: 723563760 Source-Link: googleapis/googleapis@2f843e2 Source-Link: googleapis/googleapis-gen@cd0f9c6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QwZjljNmZlMWRkNzdjNTUyZWY3NjZlNjA0N2Y4ZGNmZDNiY2MyZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update copyright year for auto-generated protos PiperOrigin-RevId: 731738802 Source-Link: googleapis/googleapis@d72ca0d Source-Link: googleapis/googleapis-gen@2734992 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjczNDk5MjBkYWU2Y2Q0YzJhNTFjMWM1YjRiNDNlMmMwMGYwMjk2NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update copyright year for auto-generated protos PiperOrigin-RevId: 732130682 Source-Link: googleapis/googleapis@9415ba0 Source-Link: googleapis/googleapis-gen@2905f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update typescript gapic generator to 4.8.1 feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671) fix: add json files to tsconfig templates (#1692) (ba6be1d) PiperOrigin-RevId: 735896588 Source-Link: googleapis/googleapis@3419af7 Source-Link: googleapis/googleapis-gen@f35ba11 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: await/catch promises, and update listOperationsAsync return type PiperOrigin-RevId: 738212310 Source-Link: googleapis/googleapis@803b234 Source-Link: googleapis/googleapis-gen@4f44bd2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Resolve the linting errors * Run the migration script * Delete the migration script * Add files to include in compilation * Cherry picking * Add void in front of a bunch of promises * Downgrade arrify * Downgrade protobufjs * npm run fix * Fix the linting errors * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update the post-processor * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Mark the test as only * skip the samples test --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* Upgrade the google-gax version * fix: More error visibility in nodejs-datastore
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* cast as any * fix: Fix the compiler error blocking the release
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
**Description:** There is an incompatibility with the current protobufjs version and it is blocking the CI pipeline. https://github.com/googleapis/nodejs-datastore/actions/runs/17623790707/job/50075476485?pr=1405 for more details **Impact:** Unblocks the CI pipeline
* Work in progress property transforms * Change entity back to any * Add the new interfaces and middleware code * Pull the build property transform into separate fn * Add arrays to the build transform function * Add a test for property transforms * Correct test comments * More modular build function * Update the test to check for the final result * Add the request spy * Fix the bug making property always increment * Fix the test based on the most recent source code change * Refactor code for the array transforms * Add a guard in case the casted type doesn’t exist * Remove only * Add a header * Remove TODO * Remove TODO * Parameterize the test * Ran linter * Run the linter * Add a comment to buildPropertyTransforms * Add comments for building the property transforms * Add two more test cases * Build the 3 test cases * should process string inputs for max/min/increment * Produce test cases for different situations * Delete invalid test cases and run linter * Correct the order of operations test * Remove only
## Description This PR is a follow-up to the PR https://github.com/googleapis/nodejs-datastore/pull/1369 which adds datastore transforms support when the user does datastore.save. It turns out that for saves with transactions no further source code changes are required because transactions call the save method so this PR simply adds some tests for transactions that save with transforms. ## Impact Ensures datastore transforms work with transactions ## Testing Added tests where datastore transforms work with transactions.
* chore(main): release 10.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1814
to
+1817
| this.baseUrl_ = baseUrl | ||
| .replace(leadingProtocol, '') | ||
| .replace(port, '') | ||
| .replace(trailingSlashes, ''); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
…eapis/google-cloud-node into nodejs-datastore-migration
GautamSharda
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-cloud-resource-prefixheader #1558)npm ciinstead ofnpm install(datastore: Ascending ordering rule should work without + sign #134)makeReq#199).save()through the datastore abstraction #384)generation#358)upload#412)Add Tasksample to index in README (The project exceeded the rate limit for creating and deleting buckets. #411)completeevent. #435)gcloud-nodewith iojs v2.0.1 & npm v2.9.1 #626)on()way of iterating. #673).github/workflows/ci.yaml(#1110) (#835)DatastoreFirestoreMigraitonMetadata(#950)ORquery support (#1064)system-test/fixturesto.eslintignore(#1170)UpdateVehicleLocationis removed from serviceVehicleService(#1248)nullvalues (#1330)Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕