Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

Reverts #2020

@stephenplusplus stephenplusplus merged commit 281e407 into master Feb 24, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2017
@stephenplusplus stephenplusplus deleted the revert-2020-http_header branch February 24, 2017 16:39
@jmuk
Copy link
Contributor

jmuk commented Mar 30, 2017

Ugh, I didn't notice this. Why reverted? This means lacking the header info for non-gapic APIs.

cc: @bjwatson @lukesneeringer

@stephenplusplus
Copy link
Contributor Author

#2020 (comment)

@jmuk - sorry, can you PR this again? Each gRPC API using GrpcService already passes in its package.json. The GrpcService class has access to it under options.packageJson.

I was suggesting we not do any code changes in packages/src/{service}/index.js, rather move them to packages/common-grpc/index.js, since it should have all the information it needs from the package.json it is sent from the extending service class.

Looking at the other PRs, I don't think you went with that style (which makes sense, if you never saw the comment), and I must have forgotten about that request, so now we're in a half-n-half state.

@jmuk
Copy link
Contributor

jmuk commented Mar 30, 2017

Created #2164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants