-
Notifications
You must be signed in to change notification settings - Fork 643
datastore: properly form deferred keys #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sfbaltaci -- would you mind trying this out? $ npm install --save stephenplusplus/gcloud-node#spp--1497 |
|
sure, i just have a problem when trying to install your branch. |
|
Woops, sorry. I forgot with the new restructured repo, it's not a one-liner to install from a PR branch anymore. The most straightforward way to try it out is by cloning: $ git clone https://github.com/stephenplusplus/gcloud-node -b spp--1497
$ cd gcloud-node/packages/compute
$ npm install
$ npm link
# cd to your project
$ npm link @google-cloud/computeWhere you're using Compute: -var compute = gcloud.compute();
+var compute = require('@google-cloud/compute')();Sorry for that being so complicated :\ |
|
It works !! |
|
Awesome, thanks for reporting and testing! @callmehiphop PTAL |
Fixes #1497
Keys need to be properly formed for the API. We were skipping a step with deferred keys.