chore: flatten ifs for fkirc/skip-duplicate-actions#1115
Merged
chiedo merged 2 commits intogithub:mainfrom Nov 9, 2020
Merged
Conversation
Contributor
Author
|
@JamesMGreene I copied over what we learned in #862 |
nschonni
force-pushed
the
flatten-skip-duplicate-jobs
branch
from
4450c7e to
d9d1736
Compare
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
2 tasks
Octomerger
pushed a commit
that referenced
this pull request
Oct 29, 2021
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Fabrízio de Royes Mello <fabriziomello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Each of the sub-steps except on that only applies when the previous steps fails are skipped if the "should skip" job evaluates to
true. It was figured out with the js-lint job that this "Skipped" jobs still allow merging of the "Required" jobs.What's being changed:
Hoist the
ifcondition for the test jobs to the root, and remove the duplicate checksifs on the sub-stepsCheck off the following: