Revert "chore: flatten ifs for fkirc/skip-duplicate-actions"#1388
Merged
Revert "chore: flatten ifs for fkirc/skip-duplicate-actions"#1388
Conversation
This reverts commit d9d1736.
JasonEtco
approved these changes
Nov 16, 2020
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Contributor
|
No worries, maybe something to flag internally. |
This was referenced Nov 14, 2021
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
Add description of 'finalized' column in 'timescaledb_information.continuous_aggregates', new since 2.7. Co-authored-by: Lana Brindley <github@lanabrindley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d9d1736 (this PR).
Over the past few days we've been running into this stall with our pull requests.
I can't explain why but I think it's because of this PR so I want to revert it and see what happens.
This is what the test suite looks like now with the fix on this PR which seems to suggest that this does fix the problem. Furthermore, the test suite on this PR is running while it isn't on others that were opened roughly 15 minutes before this PR.
Check off the following:
/cc @nschonni @github/docs-engineering