chore: Pull JS Linting to separate Action#862
Conversation
|
Thanks @nschonni! I'll get this triaged for review ⚡ |
heiskr
left a comment
heiskr
left a comment
There was a problem hiding this comment.
👏🏼 This looks like a solid improvement.
nschonni
force-pushed
the
js-linting
branch
2 times, most recently
from
69b679a to
c9a0bd4
Compare
There was a problem hiding this comment.
I love what this change achieves! 😍
However, I believe this also implies that we will be unable to make the linting job be a required check for merging into the main branch, which is less desirable. 😕
I'll confirm with the Actions support folks internally but I'm going to block this PR for now by marking my review as "Request changes". 🛑
|
No problem, if this way doesn't work, I can try and re-work it with fkirc/skip-duplicate-actions |
|
@JamesMGreene figured out a way to test it by removing the trigger on the config change, and it looks like it will stall with the "Required".
I'll try with the other action, and do the same for #541 |
|
@JamesMGreene I can't see if the now "Skipped" required check will block the commit. Can you let me know, and I can in-line the skip check flow into the |
JamesMGreene
left a comment
JamesMGreene
left a comment
There was a problem hiding this comment.
Approving to check if it meets "Required Checks"... uhh... requirements. 😅
|
Oops, looks like the branch merge triggered the |
Only trigger if JS, package, or Action file is changed
|
@JamesMGreene OK, it's back to the "Skipped" required check again |
JamesMGreene
left a comment
JamesMGreene
left a comment
There was a problem hiding this comment.
Good news! ☝🏻 It actually seems to be happy with this. 🎉
That's so awesome, @nschonni. It really cleans the test workflow up nicely. 😍
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* Add multi-node administration section Add a section on multi-node administrations. This includes: * A description of multi-node-specific limitations for administration * Role management * Database administration Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/how-to-guides/multinode-timescaledb/about-multinode.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/how-to-guides/multinode-timescaledb/multinode-administration.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/how-to-guides/multinode-timescaledb/multinode-administration.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Update timescaledb/how-to-guides/multinode-timescaledb/multinode-administration.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Nuno Santos <nunofilipesantos@gmail.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Ryan Booz <ryan@timescale.com>
5 participants
Why:
Reduce number of jobs, so the JS linting is only run if JS files are changed. I left the duplicate job run in the test-translations.yml, but it could also probably be removed if the branch filters are updated here
What's being changed:
A separate linting job that uses the pinned version of
standardrather than a floating version fromnpxrun only when JS files are changed. Relocated the previous--fixversion of the script to a separate targetCheck off the following: