This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_core][firebase_database]Add nil check for some static methods to avoid unwanted behaviors#1279
Merged
cyanglaz merged 1 commit intoflutter:masterfrom Feb 25, 2019
Conversation
This was referenced Feb 25, 2019
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
…lutter#1279) This is a similar fix following up flutter#1274
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…lutter#1279) This is a similar fix following up flutter#1274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I removed categories in #1226, I missed the nil check.
This PR is to add those nil checks to make the static method behave as the same as the category functions if the parameter is nil, this is a similar fix following up #1274