This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Conversation
added 11 commits
February 14, 2019 16:04
cyanglaz
requested review from
amirh,
kroikie,
mehmetf and
mklim
as code owners
added 2 commits
February 15, 2019 09:46
mehmetf
approved these changes
Feb 15, 2019
Contributor
mehmetf
left a comment
mehmetf
left a comment
There was a problem hiding this comment.
Is there a reason why categories is a no-no? How do we prevent them from popping up again.
The PR itself LGTM as it is just an implementation detail that does not leak to Dart API.
Contributor
Author
If there are multiple categories methods that have the same name in different plugins, and an APP imported all those plugins, when in run time, objective-c will pick up a random one and use it for all of the invocations. So it can break the project since the implementations of these same named category could be different. Details in here flutter/flutter#27960. |
This was referenced Feb 15, 2019
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Fixing [flutter/flutter#27361](flutter/flutter#27361) and [flutter/flutter#27960](flutter/flutter#27960) Used static c function instead of category. The plugins effected are cloud_firestore firebase_admob firebase_auth firebase_core firebase_database firebase_dynamiclink firebase_mlvision firebase_storage google_signin camera
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 8935485.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Fixing [flutter/flutter#27361](flutter/flutter#27361) and [flutter/flutter#27960](flutter/flutter#27960) Used static c function instead of category. The plugins effected are cloud_firestore firebase_admob firebase_auth firebase_core firebase_database firebase_dynamiclink firebase_mlvision firebase_storage google_signin camera
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Fixing [flutter/flutter#27361](flutter/flutter#27361) and [flutter/flutter#27960](flutter/flutter#27960) Used static c function instead of category. The plugins effected are cloud_firestore firebase_admob firebase_auth firebase_core firebase_database firebase_dynamiclink firebase_mlvision firebase_storage google_signin camera
cyanglaz
pushed a commit
that referenced
this pull request
Feb 25, 2019
… nil on getFlutterError (#1274) When `getFlutterError` was introduced(#1226), some plugins started to throw exceptions for successful operations. This fixed the issue. Related issues include flutter/flutter#28344; flutter/flutter#28065; flutter/flutter#28103 It also fixed an unintentional typo introduced in the same PR.(#1226)
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
… nil on getFlutterError (flutter#1274) When `getFlutterError` was introduced(flutter#1226), some plugins started to throw exceptions for successful operations. This fixed the issue. Related issues include flutter/flutter#28344; flutter/flutter#28065; flutter/flutter#28103 It also fixed an unintentional typo introduced in the same PR.(flutter#1226)
collinjackson
pushed a commit
to collinjackson/flutterfire-old2
that referenced
this pull request
Jun 24, 2019
… nil on getFlutterError (#1274) When `getFlutterError` was introduced(flutter/plugins#1226), some plugins started to throw exceptions for successful operations. This fixed the issue. Related issues include flutter/flutter#28344; flutter/flutter#28065; flutter/flutter#28103 It also fixed an unintentional typo introduced in the same PR.(flutter/plugins#1226)
collinjackson
pushed a commit
to firebase/flutterfire
that referenced
this pull request
Aug 14, 2019
… nil on getFlutterError (#1274) When `getFlutterError` was introduced(flutter/plugins#1226), some plugins started to throw exceptions for successful operations. This fixed the issue. Related issues include flutter/flutter#28344; flutter/flutter#28065; flutter/flutter#28103 It also fixed an unintentional typo introduced in the same PR.(flutter/plugins#1226)
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Fixing [flutter/flutter#27361](flutter/flutter#27361) and [flutter/flutter#27960](flutter/flutter#27960) Used static c function instead of category. The plugins effected are cloud_firestore firebase_admob firebase_auth firebase_core firebase_database firebase_dynamiclink firebase_mlvision firebase_storage google_signin camera
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Fixing [flutter/flutter#27361](flutter/flutter#27361) and [flutter/flutter#27960](flutter/flutter#27960) Used static c function instead of category. The plugins effected are cloud_firestore firebase_admob firebase_auth firebase_core firebase_database firebase_dynamiclink firebase_mlvision firebase_storage google_signin camera
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing flutter/flutter#27361 and flutter/flutter#27960
Used static c function instead of category.
The plugins effected are
cloud_firestore
firebase_admob
firebase_auth
firebase_core
firebase_database
firebase_dynamiclink
firebase_mlvision
firebase_storage
google_signin
camera