This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_core] fixing crash on iOS due to app name not found#1260
Closed
ffeu wants to merge 1 commit intoflutter:masterfrom
Closed
[firebase_core] fixing crash on iOS due to app name not found#1260ffeu wants to merge 1 commit intoflutter:masterfrom
ffeu wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
|
@collinjackson @kroikie |
Contributor
Author
|
Chris, thanks for the other PR, maybe you would like to check this one too. |
Contributor
Author
|
oh, nevermind, now I see you already pushed #1279. if you want, you could close the related issues from this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure wether it is crashing for everybody, but for the cases on which the app is not found with given name (like mine), it won't crash anymore, it just logs and continues (as it used to).
Example of the app log after this PR.
Log using current
firebase_coreversion (0.3.1):intends to
fix flutter/flutter#28248
fix flutter/flutter#28199
fix flutter/flutter#28328
fix flutter/flutter#28068