Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_core] fixing crash on iOS due to app name not found#1260

Closed
ffeu wants to merge 1 commit intoflutter:masterfrom
ffeu:getdictionaryfromfirapp
Closed

[firebase_core] fixing crash on iOS due to app name not found#1260
ffeu wants to merge 1 commit intoflutter:masterfrom
ffeu:getdictionaryfromfirapp

Conversation

@ffeu
Copy link
Contributor

@ffeu ffeu commented Feb 23, 2019

I'm not sure wether it is crashing for everybody, but for the cases on which the app is not found with given name (like mine), it won't crash anymore, it just logs and continues (as it used to).

Example of the app log after this PR.

Configuring the default Firebase app...
Configured the default Firebase app __FIRAPP_DEFAULT.
5.4.1 - [Firebase/Core][I-COR000004] App with name __FIRAPP_DEFAULT does not exist.
5.4.1 - [Firebase/Analytics][I-ACS023007] Firebase Analytics v.50001000 started
5.4.1 - [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
No app found with name 'exampleapp'
5.4.1 - [Firebase/Core][I-COR000004] App with name exampleapp does not exist.

Log using current firebase_core version (0.3.1):

Configuring the default Firebase app...
Configured the default Firebase app __FIRAPP_DEFAULT.
5.4.1 - [Firebase/Core][I-COR000004] App with name __FIRAPP_DEFAULT does not exist.
5.4.1 - [Firebase/Analytics][I-ACS023007] Firebase Analytics v.50001000 started
5.4.1 - [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
5.4.1 - [Firebase/Core][I-COR000004] App with name exampleapp does not exist.
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000105f161bb __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x00000001054b4735 objc_exception_throw + 48
	2   CoreFoundation                      0x0000000105e624ec _CFThrowFormattedException + 194
	3   CoreFoundation                      0x0000000105f85541 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 321
	4   CoreFoundation                      0x0000000105f11c9b +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	5   Runner                              0x000000010218a2e9 getDictionaryFromFIRApp + 217
	6   Runner                              0x000000010218a131 -[FLTFirebaseCorePlugin handleMethodCall:result:] + 4225
	7   Flutter                             0x00000001033ad4ba __45-[Flutt<…>

intends to
fix flutter/flutter#28248
fix flutter/flutter#28199
fix flutter/flutter#28328
fix flutter/flutter#28068

@ffeu
Copy link
Contributor Author

ffeu commented Feb 23, 2019

@collinjackson @kroikie
could you please take a look at this?
judging by the issues, I'm not the only one facing this iOS crash.

@ffeu
Copy link
Contributor Author

ffeu commented Feb 25, 2019

@cyanglaz

Chris, thanks for the other PR, maybe you would like to check this one too.

@ffeu
Copy link
Contributor Author

ffeu commented Feb 25, 2019

oh, nevermind, now I see you already pushed #1279.

if you want, you could close the related issues from this PR!

@ffeu ffeu closed this Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

2 participants