Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_core] fixing crash on iOS due to app name not found #1260

Closed
ffeu wants to merge 1 commit into from
Closed

[firebase_core] fixing crash on iOS due to app name not found #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.2

* Fixed crash on iOS related to `getDictionaryFromFIRApp`.

## 0.3.1

* Remove an assertion that can interfere with hot-restart.
Expand Down
7 changes: 6 additions & 1 deletion packages/firebase_core/ios/Classes/FirebaseCorePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,12 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
} else if ([@"FirebaseApp#appNamed" isEqualToString:call.method]) {
NSString *name = call.arguments;
FIRApp *app = [FIRApp appNamed:name];
result(getDictionaryFromFIRApp(app));
if (app == nil) {
NSLog(@"No app found with name '%@'", name);
result(nil);
} else {
result(getDictionaryFromFIRApp(app));
}
} else {
result(FlutterMethodNotImplemented);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Core, enabling connecting to multiple
Firebase apps.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_core
version: 0.3.1
version: 0.3.2

flutter:
plugin:
Expand Down