Implement socks5 proxy support using socksio#188
Closed
cdeler wants to merge 7 commits intoencode:masterfrom
Closed
Implement socks5 proxy support using socksio#188cdeler wants to merge 7 commits intoencode:masterfrom
cdeler wants to merge 7 commits intoencode:masterfrom
Conversation
cdeler
changed the title
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Nice start! Curious if CI passes with this setup 👀
cdeler
force-pushed
the
implement-socks-proxy-using-socksio
branch
3 times, most recently
from
ca5a733 to
ca73293
Compare
Contributor
Author
|
Well, I mostly implemented May be it's better to do it in another PR..? |
cdeler
changed the title
Contributor
Author
|
Converted back to draft until socks4 proxy support has been added (then we can split the PR into chunks) |
cdeler
force-pushed
the
implement-socks-proxy-using-socksio
branch
from
9b7ea7b to
f6da5c4
Compare
This was referenced Sep 25, 2020
cdeler
force-pushed
the
implement-socks-proxy-using-socksio
branch
from
f6da5c4 to
4618f88
Compare
Contributor
Author
|
I reworked this draft PR according to the @tomchristie 's comment: link So that right now The next step I want to do is to merge #199 (it's a PR about migrating PS for now this draft is only about |
Contributor
|
Now supported in 0.14.5 - https://www.encode.io/httpcore/proxies/#socks-proxy-support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final draft PR for encode/httpx#203 (I closed previous). It's based on #51, I added @yeraydiazdiaz to co-authored-by
What I did:
pproxyas a dev. dependency to have a local socks proxy serverAsyncSOCKSConnectionandSyncSOCKSConnection. For now it handles only socks5-without-auth connections