Added pproxy test fixture, which allows to test requesting through socks proxy#196
Closed
cdeler wants to merge 1 commit intoencode:masterfrom
Closed
Added pproxy test fixture, which allows to test requesting through socks proxy#196cdeler wants to merge 1 commit intoencode:masterfrom
cdeler wants to merge 1 commit intoencode:masterfrom
Conversation
c9a2f01 to
4035450
Compare
Contributor
|
I don't think this is quite what I was expecting here. |
Contributor
Author
|
You are talking about Lines 84 to 85 in 1f67394 |
Contributor
Author
|
Closing this PR, replacing it by #199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of encode/httpx#203 (draft pr is #188) I'd like to introduce the
"socks"test fixture.Using
pproxyit starts a subprocess withsocks4andsocks5(with auth and without auth) proxies on localhost.Also the PR contains some new types, required in the fixture
There is a problem: this server doesn't support
socks4aproxy (may be it's not so important)