Closed
Conversation
yeraydiazdiaz
commented
Apr 1, 2020
| origin: Origin, | ||
| proxy_origin: Origin, | ||
| socks_version: str, | ||
| user_id: bytes = b"httpcore", |
Contributor
Author
There was a problem hiding this comment.
This is required by SOCKS4.
SOCKS5 will require username/password and likely defining acceptable authentication methods. Which makes me think we might want separate AsyncSOCKS4Connection and AsyncSOCKS5Connection.
yeraydiazdiaz
commented
Apr 1, 2020
Contributor
Author
|
I realize there's a fair bit of cleanup noise as well, sorry about that. Hopefully the important bits are clear. |
yeraydiazdiaz
commented
Apr 1, 2020
Contributor
Contributor
Author
|
Yep, this branch predates the recent changes regarding proxies. Will update it soon. |
Contributor
Author
|
I think I'll hold off on this until we've decided if proxy modes are something we want at all. |
This was referenced Sep 17, 2020
Contributor
|
SOCKS5 is now supported in 0.14.5 - https://www.encode.io/httpcore/proxies/#socks-proxy-support (Not sure what we'd want to do about socks4, socks4a) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds SOCKS4 proxy support via socksio 🎉
You can test this either locally using Dante via Docker as we do in socksio or simply running an
ssh -vND <PORT> <OTHER_MACHINE>, then running the following script, assuming the proxy is running inlocalhost:1080:Before I carry on with SOCKS4A and SOCKS5 (or possibly I should open a different PR?) I'd like some feedback.