Skip to content

fix(VtkTwoView): conditionally mount tool components#342

Merged
floryst merged 1 commit intoKitware:mainfrom
PaulHax:annotation-view-switch
Jun 8, 2023
Merged

fix(VtkTwoView): conditionally mount tool components#342
floryst merged 1 commit intoKitware:mainfrom
PaulHax:annotation-view-switch

Conversation

@PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jun 8, 2023

Active Crop tool still kills views after switching view layout.

Fixes #341

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for volview-dev failed.

Name Link
🔨 Latest commit dfc44e0
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6481f824c93a0700083b1930

@floryst
Copy link
Contributor

floryst commented Jun 8, 2023

This looks good for now. We will have to investigate properly handling the cropping tool's lifecycle, since clearly it's incorrect.

@floryst floryst merged commit dd30322 into Kitware:main Jun 8, 2023
PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
fix(VtkTwoView): conditionally mount tool components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruler and Rectangle visuals disappear after changing view layout

2 participants