Skip to content

fix(VtkTwoView): conditionally mount tool components #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floryst merged 1 commit into from
Jun 8, 2023
Merged

fix(VtkTwoView): conditionally mount tool components #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/components/VtkTwoView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<div class="vtk-sub-container">
<div class="vtk-view" ref="vtkContainerRef" />
</div>
<div class="overlay-no-events tool-layer">
<div v-if="viewProxyMounted" class="overlay-no-events tool-layer">
<pan-tool :view-id="viewID" />
<zoom-tool :view-id="viewID" />
<slice-scroll-tool :view-id="viewID" />
Expand Down Expand Up @@ -206,7 +206,11 @@ import { usePersistCameraConfig } from '../composables/usePersistCameraConfig';
import CrosshairsTool from './tools/CrosshairsTool.vue';
import { LPSAxisDir } from '../types/lps';
import { ViewProxyType } from '../core/proxies';
import { useViewProxy } from '../composables/useViewProxy';
import {
useViewProxy,
useViewProxyMounted,
useViewProxyUnmounted,
} from '../composables/useViewProxy';
import { useWidgetManager } from '../composables/useWidgetManager';
import useViewSliceStore, {
defaultSliceConfig,
Expand Down Expand Up @@ -377,6 +381,18 @@ export default defineComponent({
setViewProxyContainer(null);
});

// delays mounting of vtkWidgets components until the view proxy has a container
// and vtkWidgetManager gets linked with view proxy
const viewProxyMounted = ref(false);

useViewProxyMounted(viewProxy, () => {
viewProxyMounted.value = true;
});

useViewProxyUnmounted(viewProxy, () => {
viewProxyMounted.value = false;
});

// --- Slicing setup --- //

watchEffect(() => {
Expand Down Expand Up @@ -745,6 +761,7 @@ export default defineComponent({
resizeToFit.value = true;
},
hover,
viewProxyMounted,
};
},
});
Expand Down