Conversation
…quizlabs#99, unl#1) into master: Make absolutely positioned contrast errors warnings. We can't reliably compute the contrast of text over a background if the text is absolutely positioned over the background of another element that isn't a direct parent of the text element. Conflicts: Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3.js Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
- If HTMLCS has any parse errors, such as if an included script had parse errors, PhantomJS should no longer hang. Involved adding a fail callback path through HTMLCS, and some changes to the PhantomJS side of things. - Default PhantomJS runner now gives a summary at the end of the number of errors, warnings and notices. - First stage of issue squizlabs#107: Reworking of the "labels on inputs" testing in SC 1.3.1 to align with failure F68 changes in March 2014.
Select fields without a selected option now emit a warning instead of an error. In HTML5 there is a defined value if none is selected; in HTML 4/XHTML 1.0 it is undefined, which means the message must still be emitted.
Conflicts: Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
was causing an error
Only push an error if `warning === false`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this fork up to date with the latest changes to upstream and fix a few problems that I found.