Make absolutely positioned contrast errors warnings#1
Merged
kabel merged 2 commits intounl:masterfrom Aug 11, 2014
Merged
Conversation
We can't reliably compute the contrast of text over a background if the text is absolutely positioned over the background of another element that isn't a direct parent of the text element.
kabel
added a commit
that referenced
this pull request
Aug 11, 2014
Make absolutely positioned contrast errors warnings
luketw
pushed a commit
to squizlabs/HTML_CodeSniffer
that referenced
this pull request
Aug 21, 2014
…, unl#1) into master: Make absolutely positioned contrast errors warnings. We can't reliably compute the contrast of text over a background if the text is absolutely positioned over the background of another element that isn't a direct parent of the text element. Conflicts: Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3.js Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't reliably compute the contrast of text if it is absolutely positioned. Following the DOM tree won't work, so it is better to mark it as a warning for a manual check.