Merged
Conversation
Makes typing much easier. Addresse's Will's last comment.
Unfortunately we can't use node-mocks-http to test a express.Router that has async routes. See eugef/node-mocks-http#225 router will just return undefined if the executing handler is async and so the test will have no way to wait for it to complete. Thus, we have to use supertest which starts an actual HTTP server in the background and uses a HTTP client to send requests.
Plugin API to add more applications to code-server
That's the default so it's extra visual noise.
Hopefully is a bit easier to read.
Also add a check that the domain has a dot. This covers the localhost case as well, so remove that.
Turns out that while Typescript can't infer the callback return type from it, Typescript can do the opposite and infer it from the callback return type.
This will make the route more robust since it'll work under more than just the root.
Also switch `once` to `on` since we `off` them later anyway so no point in making Node do it twice.
Feels like it parallels better with the other handlers.
I'm not sure why other builds are passing with this still in.
Co-authored-by: Anmol Sethi <hi@nhooyr.io>
Capital letters in the CLI are evil. cc @code-asher
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
ci: Add support for FreeBSD to the build process
proxy-agent: Use proxy-from-env and add docs
Update ipad.md
Symlink node_modules.asar to node_modules in lib/vscode
Fix GitHub auth
This can happen if you `yarn release` without keeping node modules.
docs: add details to updating vscode section
It requires git-lfs to pull down if you want to adjust the favicon and also the affinity designer software available only on Windows and Mac. Might be a good idea to switch to Figma at some point and commit a .fig file.
Closes #2538 Works as expected on latest Firefox and Chromium.
favicon: Add dark mode support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync with upstream
Is there an open issue you can link to?