Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
app/src/main/java/to/bitkit/ui/screens/transfer/external/ExternalNodeViewModel.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
|
Note / observation. There is a little discrepancy in behavior between Android and iOS: In those cases iOS shows both toast and success / error screen:
This edge case is not handled in iOS
Probably should be reported in iOS. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@pwltr fixes:
🆕 Dev testsNew dev tests, also added to PR description.
|
|
I tested the QuickPay flow against an external channel using docker backend and hit inconsistent behavior. Repro steps
Actual result
From the latest logs, it looks like the same invoice may be processed twice in QuickPay: the first send is initiated and the second one fails as a duplicate payment. Screen.Recording.2026-03-09.at.10.05.59.mov |
Extracted this to new issue(s) for next milestone: |
|
Starting review |
feat: add pending payment notifications
As discussed and figured out in private, this bug is not in the logic of the new PR. The root cause is the unresolved issue we have with Material3's buttons not preventing unwanted DB click. This issue must be fixed, but not in this PR as it's not a regression but rather an unfixed issue in PROD. |
jvsena42
left a comment
There was a problem hiding this comment.
Tested:
- ✅ Success and failure flows
- ✅ Multiple pending invoices
- ❌ Background notifications (missing set the brand color)
- ✅ Quickpay
- ✅ Finish / reopen app and update payment state
Thanks, fixed in a03b4b0
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


This PR adds a pending payment UI for Lightning sends that take longer than expected (e.g. hold invoices).
Description
SendPendingScreenwith an hourglass animation, shown when a Lightning payment exceeds the 10-second timeout without resolvingPendingPaymentResolutiontracking inLightningReposo payment success/failure events are routed back to the pending screenPreview
Recording
tests_1.75x.mp4
edges_1.75x.mp4
QA Notes
Setup
bitkit-docker:docker compose up -dcurl -sL https://gist.githubusercontent.com/ovitrif/ac13a7ba09efd4c12bee0a1b4cc27f4a/raw/local-electrum.patch | git applyUse
./bitcoin-cliinbitkit-dockerfor hold invoices ops:Tests
Edge Cases
No need for reviewer(s) to test edge cases, they're listed here for transparency into what was dev-tested.
🤖 Generated with Claude Code