Skip to content

Use JSONTokener JSONParserConfiguration in JSONObject and JSONArray constructors #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stleary merged 2 commits into from
Jan 19, 2025
Merged

Use JSONTokener JSONParserConfiguration in JSONObject and JSONArray constructors #948

stleary merged 2 commits into from
Jan 19, 2025

Conversation

@Simulant87
Copy link
Contributor

@Simulant87 Simulant87 commented Jan 15, 2025

fixes #947

@Simulant87 Simulant87 mentioned this pull request Jan 15, 2025
Closed
@stleary
Copy link
Owner

stleary commented Jan 17, 2025

What problem does this code solve?
Resolves a bug where the wrong JSONParserConfiguration is used when creating a JSONArray or JSONObject with a JSONTokener instance.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. New unit tests were added.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary stleary changed the title use JSONParserConfiguration of JSONTokener in JSONObject and JSONArray constructor instead of creating a new one Use JSONTokener JSONParserConfiguration JSONObject and JSONArray constructors Jan 19, 2025
@stleary stleary merged commit 22f8290 into stleary:master Jan 19, 2025
7 checks passed
@stleary stleary changed the title Use JSONTokener JSONParserConfiguration JSONObject and JSONArray constructors Use JSONTokener JSONParserConfiguration in JSONObject and JSONArray constructors Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stleary stleary stleary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: JSONObject constructor with JSONTokener ignores JSONParserConfiguration of JSONTokener

2 participants

@Simulant87 @stleary