Import ABC from collections.abc for Python 3.10 compatibility.#84
Closed
tirkarthi wants to merge 1 commit intospacepy:masterfrom
tirkarthi:fix-abc
Closed
Import ABC from collections.abc for Python 3.10 compatibility.#84tirkarthi wants to merge 1 commit intospacepy:masterfrom tirkarthi:fix-abc
tirkarthi wants to merge 1 commit intospacepy:masterfrom
tirkarthi:fix-abc
Conversation
Member
|
Thanks for taking a shot at this. Normally we try to preserve namespacing per PEP 20 (this isn't consistent throughout the codebase) and we definitely do need some tests to cover this. (I'll probably pull over the warnings testing infrastructure from SpacePy). |
8 tasks
Contributor
|
Fixed in #120 |
Member
|
Superseded by #120 for the reasons described in that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
PR Checklist
New code is easier to review, integrate and maintain if it's
consistent with the style of the rest of the dbprocessing code.
Please try to follow as much of this checklist as you can for
your PR. If a given item is not relevant to your PR, please check
it off, add "(N/A)" to the start of the line, and include a
description below the checklist.
If you don't know how to complete something in the checklist, go
ahead and submit the PR as a draft and ask for help.
Some additional suggestions are given below.
Please also see our Code of Conduct so that the dbprocessing community
remains welcoming and inclusive.
Go ahead and replace the text above (and this line!) with your
pull request description.
Closes #if this PR closes the issue, or some other reference, such asSee #if it is related in some other way)