Skip to content

Import ABC from collections.abc for Python 3.10 compatibility.#84

Closed
tirkarthi wants to merge 1 commit intospacepy:masterfrom
tirkarthi:fix-abc
Closed

Import ABC from collections.abc for Python 3.10 compatibility.#84
tirkarthi wants to merge 1 commit intospacepy:masterfrom
tirkarthi:fix-abc

Conversation

@tirkarthi
Copy link

Fixes #83

PR Checklist

New code is easier to review, integrate and maintain if it's
consistent with the style of the rest of the dbprocessing code.
Please try to follow as much of this checklist as you can for
your PR. If a given item is not relevant to your PR, please check
it off, add "(N/A)" to the start of the line, and include a
description below the checklist.

If you don't know how to complete something in the checklist, go
ahead and submit the PR as a draft and ask for help.

Some additional suggestions are given below.

Please also see our Code of Conduct so that the dbprocessing community
remains welcoming and inclusive.

Go ahead and replace the text above (and this line!) with your
pull request description.

  • Pull request has descriptive title
  • Pull request gives overview of changes
  • New code has inline comments where necessary
  • Any new modules, functions or classes have docstrings consistent with dbprocessing style
  • Major new functionality has appropriate Sphinx documentation
  • Added an entry to release notes if fixing a major bug or providing a major new feature
  • New features and bug fixes should have unit tests
  • Relevant issues are linked in the description (use Closes # if this PR closes the issue, or some other reference, such as See # if it is related in some other way)

@jtniehof
Copy link
Member

Thanks for taking a shot at this. Normally we try to preserve namespacing per PEP 20 (this isn't consistent throughout the codebase) and we definitely do need some tests to cover this. (I'll probably pull over the warnings testing infrastructure from SpacePy).

@dnadeau-lanl
Copy link
Contributor

Fixed in #120

@jtniehof
Copy link
Member

jtniehof commented Feb 4, 2022

Superseded by #120 for the reasons described in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecations: collections.abc, Engine.table_name

3 participants