Fix python 3.9 and sqlalchemy 1.4 deprecations#120
Merged
dnadeau-lanl merged 2 commits intospacepy:masterfrom Feb 4, 2022
Merged
Fix python 3.9 and sqlalchemy 1.4 deprecations#120dnadeau-lanl merged 2 commits intospacepy:masterfrom
dnadeau-lanl merged 2 commits intospacepy:masterfrom
Conversation
* ABCs from collections (spacepy#83) * 'is' comparisons to string
* table_names() removed (test only) * mapped_table replaced with persist_selectable (test only) * make subquery select explicit (DButils) * make scalar subquery explicity (newestVersionProblemFinder)
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecations for Python 3.9 (some of which would be errors in 3.10) and for sqlalchemy 1.4. Maintains support on earlier Python and sqlalchemy. Closes #83.
For Python 3.9/3.10:
collections.abcif possible (fallback tocollections)isstring comparisons with==For sqlalchemy 1.4:
table_names()was removed (affects tests only)mapped_tablewas replaced withpersist_selectable(affects tests only)DButils)newestVersionProblemFinder, which is untested)This supersedes #84, which does not fix all warnings in #83 and didn't preserve namespacing on
collections.PR Checklist
Closes #if this PR closes the issue, or some other reference, such asSee #if it is related in some other way)We don't yet have unit tests to make sure warnings aren't raised, and I didn't add them. But the tests now pass without warnings on Python 3.10 and sqlalchemy 1.4.