Merged
Conversation
for more information, see https://pre-commit.ci
…atialdata-plot into adjust_shapes_params
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 77.17% 76.80% -0.38%
==========================================
Files 12 12
Lines 1827 1927 +100
==========================================
+ Hits 1410 1480 +70
- Misses 417 447 +30
|
Merged
src/spatialdata_plot/pl/basic.py
Outdated
| ---------- | ||
| elements : list[str] | str | None, optional | ||
| element : list[str] | str | None, optional | ||
| The name(s) of the shapes element(s) to render. If `None`, all shapes |
Collaborator
There was a problem hiding this comment.
list[str] doesn't apply anymore. In general, the docstring needs to be updated in several places, right?
Contributor
Author
There was a problem hiding this comment.
yes, I will adjust the docstrings if overall the PR is accepted:) Just the type annotations already had to be changed for mypy
Sonja-Stockhaus
approved these changes
Jun 17, 2024
Contributor
Author
|
@Sonja-Stockhaus cheers for reviewing! I will adjust the docstrings after finishing PR in the spatialdata repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #267 but then for shapes.