Merged
Conversation
Contributor
Author
|
ok couple of things that "fail": The remainder of the tests were thinking at least locally for me also on main. @timtreis what is the current status of #262? I would have to merge that one in here, but right now I have no permission to actually checkout that PR with the github cli. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 77.70% 77.17% -0.53%
==========================================
Files 11 12 +1
Lines 1722 1827 +105
==========================================
+ Hits 1338 1410 +72
- Misses 384 417 +33
|
timtreis
approved these changes
Jun 1, 2024
Member
timtreis
left a comment
There was a problem hiding this comment.
Only known-to-fail tests fail. We'll fix in main after this refactor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






This PR refactors the way the parameters for image rendering get validated and passed. Some of the changes are not backward compatible. For
elementthe user can't pass on alistofstranymore, but onlystrorNone. All the passed on parameters are used to create a view config for a single element. IfelementisNonethen all the parameters are checked for whether they are valid for a specific element and if that is not the case the value of the parameter for that element is set to None. If a user wants to plot multiple specific images, thepl.rendercalls can be chained.Because of creating viewconfigs in such a way that each element has its own contained config this will make it easy to hook up vega like specifications and also to write those out.