add terraform/packages dir to initialize_datadir()#2501
Merged
sachilles merged 1 commit intosameersbn:masterfrom Jan 29, 2022
Merged
Conversation
Also add them to sanitize_datadir() Note that the backup will fail if these directories do not exist with each feature enabled.
kkimurak
deleted the
add-terraform-and-packages-to-datadir-initialization
branch
peter-jozsa
added a commit
to peter-jozsa/docker-gitlab
that referenced
this pull request
Apr 11, 2022
… during datadir initialization sameersbn#2501
peter-jozsa
added a commit
to peter-jozsa/docker-gitlab
that referenced
this pull request
Apr 11, 2022
… during datadir initialization sameersbn#2501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add them to
sanitize_datadir()In GitLab 14.7.0, backup now contains terraform state and package registry files.
The backup task will fail if these directories do not exist with each feature enabled. Currently
terraform_stateis enabled by default, user cannot change this from environment variables likeGITLAB_TERRAFORM_STATE_ENABLED.Note: path for terraform state is not parameterized. PR is on #2438 so we have to replace the path with parameterized one if the PR is accepted.