Allow to configure Terraform State

[peter-jozsa]

The goal of this PR is to introduce new configuration variables for Terraform State management feature of GitLab. The new params let users:

• enable/disable Terraform State management
• override the default local storage path
• enable/disable Object Store for terraform states
• setup an AWS bucket for Object Store
• setup a GCS bucket for Object Store

[peter-jozsa]

@sachilles @sameersbn is there any chance this PR will be accepted in the near future?

[sachilles]

@peter-jozsa I think so. But I'll need some time to understand the details in your PR (and get warm with Terraform).

[sachilles]

@peter-jozsa Sorry for my late reply. I will include your PR before the #2465 . However, I will not be able to check it until the weekend or next week.

[peter-jozsa]

alright, thank you! anyway in the end we ended up not using terraform state management but we are planning to use it in the near future

[sachilles]

Hi, I think that for now I will rather update GitLab to stay up to date with the upstream.

[ymazzer]

Hi, this feature would be wonderful for people using terraform.

As of now, the state is stored using the tmp local folder which does not seem very safe.

Any change to merge it soon? Or at least to change default terraform state storage location to something like /home/git/data/terraform_state?

[paolomainardi]

Hi everyone, @sachilles are there any chances to have this one merged ?

[peter-jozsa]

hi 👋
I rebased my modifications on current master. Hopefully we can speed things up here.

[paolomainardi]

thanks a lot @peter-jozsa

[sachilles]

Hi,

I'll do my very best to understand the terraform configuration.

[Syphon83]

Hi,

I'll do my very best to understand the terraform configuration.

This feature would be great!
Terraform files should follow the same flow for the objects storage as uploads or artifacts files.

Hope to see this merged soon! Thank you for your work!

[paolomainardi]

@sachilles are we still in time to have this one merged before 14.10 ?

[paolomainardi]

@sachilles sorry for chasing, are you planning to merge this one for the next release ?

[sachilles]

Hi, I'm planning to merge this PR.

Please be patient. I think I will get to the final review tonight.

[sachilles]

Thanks for this very valuable post and sorry for the long wait (and subsequent rework). Nevertheless, could you include the small changes in the documentation?

[sachilles]

Please change AWS_PATH_STYLE to $AWS_PATH_STYLE

[sachilles]

Please change this sentence to:

Connection Provider for the Object Store (AWS or Google). Defaults to $GITLAB_OBJECT_STORE_CONNECTION_PROVIDER (i.e. AWS).