feat(rebase): updating our fork with the latest upstream by erunion · Pull Request #180 · readmeio/httpsnippet

erunion · 2023-06-16T19:29:11Z

It's been about a year now since I last rebased upstream into our fork! 😅

🧰 Changes

Updated everything to the latest upstream.
Fixed a bug in php:curl snippets where booleans were being changed to null

see Kong#248 and the commits therein for more context. Essentially: - the original client fixtures were unchanged, which hopefully means the - all source code is now in strict mode TypeScript - tests are now all in jest - the file structure was reorganized so that everything for a particular client is in one place - the CLI is updated and now using yargs - all dependencies were updated and some (i.e. `format.utils`) were able to be removed entirely - more work left to do (including CI with GitHub Actions, for example), but this is a start

) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* Add Github Build Workflow (#250) * Edit job name * Replace install with ci on GH workflow * Add matrix with major node versions (14, 16, 18) * Disable fail-fast * Remove node v14 from build GH action

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

…257) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* Remove travis links * Update README.md Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

…#269) * fix: issue where query strings in R wouldn't be properly concatenated * adds (and respects) indent options to httr, plus double looping fix now, indent is respected, and also avoiding running Object.keys twice per run since we can just run it once with .entries Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* add header namesspace to prevent header errors * update fixtures Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* swift/nsurlsession adds `as Any` to print for error * adds OVERWRITE_EVERYTHING to ease fixture snapshot resetting * updates fixtures Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Co-authored-by: Sergey Zakharchenko <szakharchenko@digital-loggers.com>

…ost params (#192) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

…#198) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* go/native: adds insecureSkipVerify * node/native: adds insecureSkipVerify * python/python3: adds insecureSkipVerify * ruby/native: adds insecureSkipVerify * shell/curl: adds insecureSkipVerify Co-authored-by: Tim Perry <pimterry@gmail.com>

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Co-authored-by: Tim Perry <pimterry@gmail.com>

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

* php/curl: use json_encode for CURLOPT_POSTFIELDS * php/http1: use json_encode when body is JSON * php/http2: use json_encode when body is JSON Co-authored-by: Andrii Kostenko <andrey@kostenko.name>

* Exclude package.json from build to fix output paths * keeps bin pointing at cli output * makes rootDir explicit * removes unused cli build scripts Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Co-authored-by: Filipe Freire <livrofubia@gmail.com>

src/targets/node/native/fixtures/insecure-skip-verify.js

erunion · 2023-06-16T22:10:36Z

src/fixtures/requests/application-json.js

          ],
          postData: {
            mimeType: 'application/json',
-            text: '{"number":1,"string":"f\\"oo","arr":[1,2,3],"nested":{"a":"b"},"arr_mix":[1,"a",{"arr_mix_nested":{}}],"boolean":false}',


Changed to this part of this fixture to an empty array because the empty object was throwing off some of our unit test assertions.

erunion · 2023-06-16T22:13:24Z

src/targets/php/helpers.ts

+    case '[object Boolean]':
+      return obj;


Any JSON object with a boolean in here was having that boolean rewritten to null. woof

…cker

dimitropoulos and others added 30 commits April 26, 2022 08:30

fix: case where if postData.params is missing some targets crash (#258

c7eae4c

) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: compatibility issues on node 14 with Object.hasOwn() (#252)

998e403

fix: typo in the httpie style option not being correctly applied (#254

f64080d

) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: axios targets not sending x-www-form-urlencoded properly (#255)

cd4bb4c

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

feat: addition of a PHP target for Guzzle (#253)

62d158d

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Add Github Build Workflow (#250) (#251)

0e0728a

* Add Github Build Workflow (#250) * Edit job name * Replace install with ci on GH workflow * Add matrix with major node versions (14, 16, 18) * Disable fail-fast * Remove node v14 from build GH action

feat: native upload support in python requests snippets (#259)

411844f

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: multipart/form-data header issues with node/js fetch targets (#…

3119335

…257) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: headers not being properly applied to R httr snippets (#263)

5e8f161

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Fix build workflow dispatch rules (#265)

8ca9771

Chore: Remove travis links (#266)

97731b1

* Remove travis links * Update README.md Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

add header namesspace to prevent header errors (#247)

d4bebe4

* add header namesspace to prevent header errors * update fixtures Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: stop implicitly coercing warning in Swift snippet generator (#195)

da711e9

* swift/nsurlsession adds `as Any` to print for error * adds OVERWRITE_EVERYTHING to ease fixture snapshot resetting * updates fixtures Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: clj-http handling of literal null JSON bodies (#283)

3c9e6a6

Co-authored-by: Sergey Zakharchenko <szakharchenko@digital-loggers.com>

fix: prevent crash in Swift/Objc with checking length of input body p…

7da8c97

…ost params (#192) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

fix: cUrl target should encode x-www-form-urlencoded post data params (…

12aa17e

…#198) Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

feat: implementing cleaner handling of JSON in cURL snippets (#256)

735e69a

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

chore: minor cleanup (#286)

8ea7e13

feat: use curl's --compressed option for requests that accept it (#287)

19f1b2f

feat: make Python snippets simpler, clearer & more consistent (#288)

2f7525d

Co-authored-by: Tim Perry <pimterry@gmail.com>

feat: change the default response code for Python Requests (#181)

4ac5253

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

feat: PHP JSON body encoding (#291)

a92b4fc

* php/curl: use json_encode for CURLOPT_POSTFIELDS * php/http1: use json_encode when body is JSON * php/http2: use json_encode when body is JSON Co-authored-by: Andrii Kostenko <andrey@kostenko.name>

Async/Await (top level) support in JavaScript snippets (#292)

5ec84e0

Exclude package.json from build to fix output paths (#294)

1dda869

* Exclude package.json from build to fix output paths * keeps bin pointing at cli output * makes rootDir explicit * removes unused cli build scripts Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>

Fix crash when building nsurlsession snippets for empty params (#295)

911ab77

removes require 'openssl' from ruby target (no longer needed) (#296)

cd2a0cc

Escape quotes in headers correctly in all languages (#289)

bf019b3

dimitropoulos and others added 3 commits August 30, 2022 12:07

updates README (#299)

7c00d05

Co-authored-by: Filipe Freire <livrofubia@gmail.com>

ioutil -> io (deprecated) (#305)

cee79a5

Merge remote-tracking branch 'upstream/master' into rebase/upstream

f289c7d

github-advanced-security bot found potential problems Jun 16, 2023

View reviewed changes

src/targets/node/native/fixtures/insecure-skip-verify.js Fixed Show fixed Hide fixed

erunion added 12 commits June 16, 2023 12:57

chore: undoing unwanted changes

20da8c8

chore: revert more unwanted changes

69141c7

chore: reverting more unwanted changes

1d3265e

fix: fixing broken test snapshots and libcurl not escaping

903367e

fix: a bunch of broken tests

08fc41e

fix: removing dead code

1d8b372

fix: remove support for insecureSkipVerify as we dont need or want it

9def8af

fix: removing top-level await changes for axios

ba3a0b7

fix: revert top-level await changes for js:fetch

c8c0afd

fix: remove some problematic changes to node:request

9b8e863

fix: retaining line trimming in powershell snippets

eb26f40

fix: bug in php snippets where booleans were casted to null

6b49e04

erunion commented Jun 16, 2023

View reviewed changes

erunion added 7 commits June 16, 2023 15:17

fix: revert problematic changes to python:requests

5d083ab

fix: revert more unwanted changes

0171351

chore: temporarily skipping the integration suite

7b85447

fix: broken snapshot

f6c9d4f

fix: disabling the integration suite from being run without inside do…

5a328a6

…cker

fix: integration suite

5c4c8c4

fix: integration suite

5e56dbc

erunion marked this pull request as ready for review June 16, 2023 22:47

erunion added the enhancement New feature or request label Jun 16, 2023

erunion merged commit c085c36 into main Jun 16, 2023

erunion deleted the rebase/upstream branch June 16, 2023 22:47

llimllib mentioned this pull request Jun 17, 2023

The integration tests are all disabled #183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rebase): updating our fork with the latest upstream#180

feat(rebase): updating our fork with the latest upstream#180
erunion merged 52 commits intomainfrom
rebase/upstream

erunion commented Jun 16, 2023 •

edited

Loading

Uh oh!

Uh oh!

erunion Jun 16, 2023

Uh oh!

erunion Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

erunion commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧰 Changes

Uh oh!

Uh oh!

erunion Jun 16, 2023

Choose a reason for hiding this comment

Uh oh!

erunion Jun 16, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erunion commented Jun 16, 2023 •

edited

Loading