feat: dropping support for node 16 + esm compat#198
Merged
Conversation
erunion
changed the title
erunion
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| test(`should return the expected response for \`${fixture}\``, () => { | ||
| const basePath = path.join('src', 'targets', targetId, clientId, 'fixtures', `${fixture}${extname(targetId)}`); | ||
| const fixtureExtension = extname(targetId, clientId); | ||
| const basePath = path.join('src', 'targets', targetId, clientId, 'fixtures', `${fixture}${fixtureExtension}`); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
Member
Author
There was a problem hiding this comment.
Marked this as invalid because this is a unit test.
erunion
commented
Sep 13, 2023
| context: . | ||
| dockerfile: integrations/python.Dockerfile | ||
| command: 'npx jest src/integration.test.ts' | ||
| command: 'npx vitest run src/integration.test.ts' |
Member
Author
There was a problem hiding this comment.
Have to use the run command here because Vitest doesn't know in this Docker container that it's being run in a CI environment and it'll sit there in watch mode.
erunion
commented
Sep 13, 2023
Member
Author
There was a problem hiding this comment.
Had to rename these all to be .cjs because they the snippet that's being generated here uses require().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
.jsand.cjsto every file import as well as shifting around how clients and targetsextnameis setup as our Node snippets are generating snippets withrequire()and thus need to have.cjsextensions now. Without this work all integration tests for these were failing as you can't userequire()in a.jsfile whentype: moduleis present.