Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches#1542
Merged
kandersolar merged 10 commits intopvlib:mainfrom Nov 11, 2022
Merged
Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches#1542kandersolar merged 10 commits intopvlib:mainfrom
kandersolar merged 10 commits intopvlib:mainfrom
Conversation
Closed
AdamRJensen
approved these changes
Nov 11, 2022
Member
AdamRJensen
left a comment
There was a problem hiding this comment.
@kanderso-nrel I ran the asv locally without issues and reviewed the code changes (to my best efforts). So from my side it looks good, though that might not be saying much
Member
Author
|
Thanks @AdamRJensen, yeah this stuff isn't the easiest to review. The good news is that this isn't really critical infrastructure either :) I think the real proof of review will just be to keep an eye on the asv runs and make sure they're doing the right thing, so I'll go ahead and merge this now. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR fixes several things:
asvdefaults to callingsetup.pyand wasn't calculating the version string correctly anymore. This affected both our "quick" CI check and the nightly VM job.