Remove benchmarks for deprecated SingleAxisTracker #1535
Merged
kandersolar merged 7 commits intopvlib:mainfrom Nov 11, 2022
Merged
Remove benchmarks for deprecated SingleAxisTracker #1535kandersolar merged 7 commits intopvlib:mainfrom
kandersolar merged 7 commits intopvlib:mainfrom
Conversation
Contributor
Author
|
sorry for creating another pull request for the same issue, I ran into some technical issue so i've created a new one |
kandersolar
approved these changes
Sep 1, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Thanks @Naman-Priyadarshi for this PR, and sorry for the delayed response here! This looks good to me, but we should hold off on merging it until the problem in #1542 is fixed.
Member
|
Merging this now that #1542 is in. Thanks again @Naman-Priyadarshi! |
kandersolar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmarks/tracking.pyforSingleAxisTrackerdeprecation #1508docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Removed
time_tracker_singleaxisfunction from the benchmark file asSingleAxisTrackerhas been deprecated.