OPRUN-3965: [OTE]: Add binary in the operator controller image to allow proper integration with OCP tests#403
Conversation
|
@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b4aadc0 to
4ae1ee2
Compare
|
@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4ae1ee2 to
a270a57
Compare
|
/lgtm @camilamacedo86 after it is merged and new the ocp payload is delivered (I mean you could see the green build which has this PR in https://openshift-release.apps.ci.l2s4.p1.openshiftapps.com/#4.20.0-0.nightly), the openshift/origin#29949 will pass |
|
for me, I am not sure if the command in openshift/origin#29949 (comment) is ok because the key point is that the ocp cluster must be installed with the ocp load which has the external binary. but, after this PR is merged, the openshift/origin#29949 will pass after the new ocp load is generated. so, could merge this PR firstly. |
|
/lgtm cancel others are lgtmed. |
… to allow proper integration with OCP tests
a270a57 to
7c90025
Compare
|
Hi @kuiwang02
Fixed. My main branch was outdated that is why it endup missing 2 lines |
|
@camilamacedo86 thanks for quick action. /lgtm |
|
/approve |
|
@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: This pull request references OPRUN-3965 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
8 similar comments
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kuiwang02, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
2 similar comments
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
/test openshift-e2e-aws |
|
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
982e725
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-catalogd |
Due to current limitations, it appears we cannot maintain a dedicated Dockerfile solely for injecting the binary into OCP images while keeping it isolated and registered cleanly in openshift/origin.
This PR introduces the following changes:
These changes streamline the build pipeline while aligning with OCP image handling constraints.
The changes here is to allow us : openshift/origin#29949
Important
We could confirm that works
See that we run the test with this PR: https://github.com/openshift/origin/pull/29949/checks?check_run_id=45783243053
And looking the logs we can see the bin: https://prow.ci.openshift.org/log?container=test&id=1943585495564947456&job=multi-pr-openshift-origin-29949-openshift-origin-29949-openshift-operator-framework-operator-controller-403-e2e-aws
Without this PR we see the error when the olmv1 ext bin is not found see:
IN: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29949/pull-ci-openshift-origin-main-e2e-aws/1942986031485685760